Column.with_name doesn't operate as expected about asyncqlio

[Fuyukai]

Whoops, this was an oversight in the quickfix I added.

[marcoceppi]

For now, I've worked around it by dropping .with_name and just creating @property decorators for the remaps. Though this is just for getting, doesn't address querying, setting, etc.

class Camp(Table, table_name='camps'):
    id = Column(Integer, primary_key=True, unique=True)
    lat = Column(Numeric(12, 8), nullable=False)
    lon = Column(Numeric(12, 8), nullable=False)

    @property
    def tal(self):
        return self.lat

[Fuyukai]

I think the issue for with_name not working is because the __set_name__ overwrites it in the constructor.

[marcoceppi]

Yeah, it seems TableMeta.__init__ calls Column.__set_name__. However, even when I override the Column name (above), during the query when mapping results to a Table object it's unable to map that lat schema column is tal Column object.

I haven't dug into that side of the code yet.

[Fuyukai]

get_column lied and never looked up columns by name; this should address that (hopefully).

[marcoceppi]

There's one last piece getting caught up, Columns created with_name don't get their table reference set. Not sure where that happens, I skimmed orm.schema.table with no real luck.

Traceback (most recent call last):
  File "test.marco.py", line 40, in <module>
    loop.run_until_complete(test())
  File "/usr/lib/python3.6/asyncio/base_events.py", line 467, in run_until_complete
    return future.result()
  File "test.marco.py", line 33, in test
    u = await sess.select(Camp).where(Camp.id == 1).first()
  File "/home/marco/Projects/asyncqlio/asyncqlio/orm/query.py", line 310, in first
    row = await gen.next()
  File "/home/marco/Projects/asyncqlio/asyncqlio/orm/query.py", line 122, in next
    return await self.__anext__()
  File "/home/marco/Projects/asyncqlio/asyncqlio/orm/query.py", line 116, in __anext__
    return self.query.map_columns(rows[0])
  File "/home/marco/Projects/asyncqlio/asyncqlio/orm/query.py", line 352, in map_columns
    val = row.get_column_value(column, return_default=False)
  File "/home/marco/Projects/asyncqlio/asyncqlio/orm/schema/table.py", line 955, in get_column_value
    raise ValueError("Column table must match row table")
ValueError: Column table must match row table

It doesn't happen on standard Column.__init__

[marcoceppi]

Oh, that makes sense I'm not sure why I confused owner with psql owners and not the table name.

This unblocks me, there are nitpicks about data displays, reprs, and generate_schema, but I'll work to patch those later.