futagoza / epeg.js Goto Github PK

You obviously have no intention of maintaining peg.js, and in your three year tenure, nothing has gotten released, zero maintenance has occurred, and you've started work on three other peg generators as well as two other programming languages, none of which have any commits.

Please turn the project over to someone who cares about it, so that it can get maintained, now.

Currently the value for StringLiteral is constructed using various rules to parse and return characters, and then the matched result is joined using Array#join:

StringLiteral "string"
  = '"' chars:DoubleStringCharacter* '"' { return chars.join(""); }
  / "'" chars:SingleStringCharacter* "'" { return chars.join(""); }

Should I use the PEG.js expression type $ to return the matched text (instead of matched result), and then use jsesc to escape and return a safe representation of the string:

{ const jsesc = require( "jsesc" ); }

StringLiteral "string"
  = '"' chars:$DoubleStringCharacter* '"' { return jsesc(chars, { quotes: "single" }); }
  / "'" chars:$SingleStringCharacter* "'" { return jsesc(chars, { quotes: "double" }); }

This change should only be considered if it can maintain performance while returning a safe and correct representation of the string.

If using jsesc decreases performance, consider using some other way of either concating the array into a string, or escaping the matched text.