exchangeRefreshTokenForAccessToken breaks compatibility with node-client about fusionauth-typescript-client

[ulybu]

Hi,

"@fusionauth/node-client": "1.16.0" => "@fusionauth/typescript-client": "1.17.0"

@mooreds edited, copy/pasted twice the same lib 🔝

[mooreds]

Hiya!

Thanks for letting us know.

What version of the node client were you running previously? What version of the typescript client are you moving to?

[ulybu]

Hi,

I think it could come from the fact that in the node-client lib the body is explicitly serialized with JSON.stringify queryString.stringify, which will effectively remove any undefined prop, like for instance scope if not provided to exchangeRefreshTokenForAccessToken

https://github.com/FusionAuth/fusionauth-node-client/blob/0a5c326adc097c85e3572244f70f25088e3de061/lib/RESTClient.js#L74

setFormBody: function(body) {
    this.body = queryString.stringify(body);
    this.header('Content-Type', 'application/x-www-form-urlencoded');
    this.header('Content-Length', Buffer.byteLength(this.body));
    return this;
},

Whereas in typescript-client (this repo) the missing JSON serialization means we're going to keep that scope key explicitly set to undefined.

fusionauth-typescript-client/src/DefaultRESTClient.ts

Line 85 in 0c0c36b

this.body = body;

Edit: JSON.stringify => queryString.stringify. Issue is still the same, queryString also removed any undefined props

[mooreds]

That sure looks like a incompatibility to me. I'll take a look. We also welcome pull requests if you want to just patch DefaultRESTClient.ts.

[ulybu]

We also welcome pull requests if you want to just patch DefaultRESTClient.ts

Ugh, that seems too risky to me because I don't know the reason why the dropped the queryString.stringify in the first place. I can't just assume that's an oversight, right? I might very well be breaking something for someone else by adding queryString.stringify

I could submit a PR and let you guys deal with that risk assessment?

[mooreds]

No worries, I ended up submitting a PR (#32), so no effort needed on your part. Thanks again for reporting this.