Coder Social home page Coder Social logo

Comments (5)

david-chalk avatar david-chalk commented on June 28, 2024

Requesting comments and thoughts from @mooreds.

from fusionauth-react-sdk.

michaelyons avatar michaelyons commented on June 28, 2024

Requesting comments and thoughts from @lyleschemmerling

from fusionauth-react-sdk.

lyleschemmerling avatar lyleschemmerling commented on June 28, 2024

I don't think is a bad idea, but as I just commented on #89 I do think we should be using the sdk example repo as the primary limtus for the functionality of the sdk. This will ensure that it does work with FusionAuth the way that we intend, and we also expect our customer we use these as well as a guide for setting up their own applications. Extra mocking in-repo would be nice as a bonus but I don't think is required

from fusionauth-react-sdk.

david-chalk avatar david-chalk commented on June 28, 2024

@lyleschemmerling Testing the SDKs in the example and quickstart repos is a great thing to do but that doesn't take away the benefit of having more robust tests within the project itself. We can't easily incorporate that style of testing in CI/CD processes in GitHub during releases - we can setup up some E2E testing like that but it's more complicated than setting up MSW.

I'm fine marking this as a "maybe later" thing though if we don't see a big benefit for right now. 👍

from fusionauth-react-sdk.

lyleschemmerling avatar lyleschemmerling commented on June 28, 2024

let's keep this as "maybe later"

from fusionauth-react-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.