Comments (5)
Requesting comments and thoughts from @mooreds.
from fusionauth-react-sdk.
Requesting comments and thoughts from @lyleschemmerling
from fusionauth-react-sdk.
I don't think is a bad idea, but as I just commented on #89 I do think we should be using the sdk example repo as the primary limtus for the functionality of the sdk. This will ensure that it does work with FusionAuth the way that we intend, and we also expect our customer we use these as well as a guide for setting up their own applications. Extra mocking in-repo would be nice as a bonus but I don't think is required
from fusionauth-react-sdk.
@lyleschemmerling Testing the SDKs in the example and quickstart repos is a great thing to do but that doesn't take away the benefit of having more robust tests within the project itself. We can't easily incorporate that style of testing in CI/CD processes in GitHub during releases - we can setup up some E2E testing like that but it's more complicated than setting up MSW.
I'm fine marking this as a "maybe later" thing though if we don't see a big benefit for right now. 👍
from fusionauth-react-sdk.
let's keep this as "maybe later"
from fusionauth-react-sdk.
Related Issues (20)
- Source Maps Missing HOT 1
- allow withRole to take an array of values
- No error message when the wrong client id is provided HOT 4
- refreshToken() does not work without implicitly setting tokenRefreshPath HOT 2
- customize the name of the `isAuthenticated` cookie HOT 2
- /me fetch failure causing infinite loop HOT 1
- Tests causing 'not wrapped in act(...)' warning
- Update README to mention hosted endpoint support
- Remove `async` from non-async function definitions
- Repo contains both `yarn.lock` and `package-lock.json` HOT 1
- Do not use multiple package managers
- Specify node/npm version
- Provider needs error handling
- Correct component tests usage of testing-library and async
- v1.0.5 doesn't contain any code HOT 2
- [RFC] Utilize Storybook for UI development HOT 5
- [RFC] Refactor FusionAuthProvider HOT 5
- Inline documentation for SDK
- Remove "Server code requirements" from React SDK README HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fusionauth-react-sdk.