Coder Social home page Coder Social logo

Comments (7)

sherlockmac avatar sherlockmac commented on June 30, 2024 3

I can confirm this works with ACF PRO 5.8.4

acf-qtranslate/src/acf_5/fields/image.php

if (method_exists($this, 'wp_prepare_attachment_for_js')) { 
    add_filter('wp_prepare_attachment_for_js', array($this, 'wp_prepare_attachment_for_js'), 10, 3);
}

from acf-qtranslate.

pszurgot avatar pszurgot commented on June 30, 2024 2

Use ACF 5.8.2 or use qTranslate-XT (it works with acf 5.8.3 and this plugin).

https://support.advancedcustomfields.com/forums/topic/media-library-broken-after-update-to-acf-5-8-3-with-acf-qtranslate/

from acf-qtranslate.

NorioTakenaga avatar NorioTakenaga commented on June 30, 2024 1

Same issue on my project with ACF 5.8.3.

I commented out a hook on line 75 in acf-qtranslate/src/acf_5/fields/image.php.
Then media library works well.
If anyone want to try, please comment out or remove this line in acf-qtranslate/src/acf_5/fields/image.php.

add_filter('wp_prepare_attachment_for_js',array($this, 'wp_prepare_attachment_for_js'), 10, 3);

or, should change the code like this

    if (method_exists($this, 'wp_prepare_attachment_for_js')) {
			add_filter('wp_prepare_attachment_for_js', array($this, 'wp_prepare_attachment_for_js'), 10, 3);
    }

acf_qtranslate_acf_5_image class in this file must be an inheritance of acf_field_image class in advanced-custom-fields-pro/includes/fields/class-acf-field-image.php.

But it seems that in ACF 5.8.3, a function (wp_prepare_attachment_for_js) has been removed from the file and a hook using that function is removed too.
It seems that this function has been moved to line 165 in advanced-custom-fields-pro/includes/media.php.
So I think this caused the issue.

I still wonder whether this would be a right solution or not, so I hope somoene will try this.

from acf-qtranslate.

jlavnv avatar jlavnv commented on June 30, 2024 1

thanks @sherlockmac I was very headache with this problem, thank you for sharing

from acf-qtranslate.

bernester avatar bernester commented on June 30, 2024

same problem here. unfortunately i can not disable the plugin this easaly. terminal prompts the following error
Uncaught TypeError: Cannot read property 'prototype' of undefined at qtranslatex.js?ver=5.2.2:95 at dispatch (load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils&ver=5.2.2:3) at r.handle (load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils&ver=5.2.2:3) (anonymous) @ qtranslatex.js?ver=5.2.2:95 dispatch @ load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils&ver=5.2.2:3 r.handle @ load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils&ver=5.2.2:3 load (async) add @ load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils&ver=5.2.2:3 a.event.add @ load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils&ver=5.2.2:8 (anonymous) @ load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils&ver=5.2.2:3 each @ load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils&ver=5.2.2:2 each @ load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils&ver=5.2.2:2 ra @ load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils&ver=5.2.2:3 on @ load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils&ver=5.2.2:3 (anonymous) @ acf-input.min.js?ver=5.8.3:1 (anonymous) @ acf-input.min.js?ver=5.8.3:1

from acf-qtranslate.

bichonnages avatar bichonnages commented on June 30, 2024

Same thing here.

from acf-qtranslate.

jisanpolara avatar jisanpolara commented on June 30, 2024

Hi,

This plugin is working fine now. Wow.
https://github.com/qtranslate/qtranslate-xt

from acf-qtranslate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.