-dns switch to use custom dns server is not working in Windows, still uses OS settings about pyfunceble

[opav]

That snippet works!

It went directly to 8.8.8.8. Confirmed my DNS log has no queries. And also saw the outbound packets going to 8.8.8.8 from my router's tcpdump trace.

[opav]

So I just installed latest PyF-dev and this time x64 Python (https://www.python.org/downloads/windows/) but it is still going to my DNS instead of 8.8.8.8:

pyfunceble 2.13.0.dev (Green Galago: Skitterbug)
Python 3.7.4 (tags/v3.7.4:e09359112e, Jul 8 2019, 20:34:20) [MSC v.1916 64 bit (AMD64)]

[funilrys]

Hi @opav,

Sorry for the delay, I had to setup Windows 10 so that I can develop and try to debug from there.

May I ask how do determine that PyFunceble still uses the OS settings ?

Also, thanks for using the dev branch! Feedback from the dev branch helps a lot!

Today (Berlin Time) I made a push to the dev, it includes the logger.
Can you update to the latest version and give me the content of output/logs/debug.log after running the following ?
WARNING if you don't want to expose your DNS IP/Server Name, please anonymize or send the log privately per email or KeyBase (prefered). All issue/debug data shared privately with me will be safely destroyed from my machine and Keybase once the issue is resolved.

> PyFunceble -d google.com --debug --no-whois --dns yourDNSServer 

Thanks again for your feedback.

Cheers,
Nissar

[funilrys]

Hi @opav,

Can you test if the patch I just pushed fixes your issue?

Cheers,
Nissar

[opav]

Sorry was away, will test it shortly.

[opav]

Hi @funilrys ,

I install a fresh pyfunceble 2.11.6.dev (Green Galago: Skitterbug) with all defaults and the problem still persist.

I can confirm it is still using my OS DNS (which points to a DNS server on my network), from the queries in my DNS server log.

debug.log

Hope the log helps, thank you.

[mitchellkrogza]

Tested on Windows 10 @funilrys @opav
PyFunceble 2.13.0.dev

Does indeed use the external DNS server I specified.
This test conducted inside a miniConda environment on Windows 10.

[opav]

I am on Windows 7 and I noticed the Python version is a bit different from @mitchellkrogza , mine says:

Python 3.7.4 (tags/v3.7.4:e09359112e, Jul 8 2019, 19:29:22) [MSC v.1916 32 bit (Intel)]

[funilrys]

I came to the same conclusion as @mitchellkrogza .... But we are using Windows 10 😞

Can you test the following locally and tell me if there is a difference (from the DNS log)

import dns.resolver

# This is the part we do.
# We don't touch the default resolver, we use a new one.
our_resolver = dns.resolver.Resolver(configure=False)
our_resolver.nameservers = ["8.8.8.8"]

print(our_resolver.query('google.com', 'A').response)

print("*" * 50)

# This is the part we don't do and the possible solution for your case.
# We replace the default resolver. and work with it.
dns.resolver.default_resolver = dns.resolver.Resolver(configure=False)
dns.resolver.default_resolver.nameservers = ['8.8.8.8']

print(dns.resolver.query('google.org', 'A').response)

Cheers,
Nissar

[mitchellkrogza]

Do you have any DNS servers hard coded in your network settings? With windows that could well be a cause of what you experienced.

[funilrys]

@opav which one worked? google.com or google.org ?

[opav]

Both queries works. Meaning both went direct to 8.8.8.8.

Think we are getting close to the issue.

id 44003                                          
opcode QUERY                                      
rcode NOERROR                                     
flags QR RD RA                                    
;QUESTION                                         
google.com. IN A                                  
;ANSWER                                           
google.com. 142 IN A 172.217.194.113              
google.com. 142 IN A 172.217.194.138              
google.com. 142 IN A 172.217.194.139              
google.com. 142 IN A 172.217.194.100              
google.com. 142 IN A 172.217.194.101              
google.com. 142 IN A 172.217.194.102              
;AUTHORITY                                        
;ADDITIONAL                                       
**************************************************
id 27511                                          
opcode QUERY                                      
rcode NOERROR                                     
flags QR RD RA                                    
;QUESTION                                         
google.org. IN A                                  
;ANSWER                                           
google.org. 300 IN A 216.239.32.27                
;AUTHORITY                                        
;ADDITIONAL 

[funilrys]

@opav What if you run ?

PyFunceble -d github.com --http --dns yourDNSServer --no-whois

[opav]

This works as expected, went to 8.8.8.8 as specified -
PyFunceble -d github.com --http --dns 8.8.8.8 --no-whois

.....

I also trace thru dns_lookup.py and it seems for the earlier commands, the code is getting results from this, the default OS resolver, instead of my specified --dns server?

PyFunceble/PyFunceble/dns_lookup.py

Line 350 in 02032fc

req = getaddrinfo(subject, 80, proto=IPPROTO_TCP)

[funilrys]

Nope, our issue is actually coming from :

PyFunceble/PyFunceble/http_code.py

Lines 151 to 166 in 02032fc

	req = PyFunceble.requests.head(
	self.subject,
	timeout=PyFunceble.CONFIGURATION.timeout,
	headers=self.headers,
	verify=PyFunceble.CONFIGURATION.verify_ssl_certificate,
	)
	else:
	# We are not globally testing a URL.
	# We get the head of the constructed URL.
	req = PyFunceble.requests.head(
	self.subject,
	timeout=PyFunceble.CONFIGURATION.timeout,
	headers=self.headers,
	verify=PyFunceble.CONFIGURATION.verify_ssl_certificate,
	)

The patch is written but I'm doing some review of the patch itself in order to avoid a big performance loss.

[funilrys]

@opav As the new version was released by the CI tool, can you test and tell us ? https://pypi.org/project/PyFunceble-dev/#files

P.S: Please DO NOT close this issue manually. This issue is going to be closed automatically once 5398233 will be merged to master.