Coder Social home page Coder Social logo

Comments (6)

fundamental avatar fundamental commented on July 25, 2024

Oh goodness boost, that's a long type signature.

I'd side with just truncating the signatures as the YAML files do make it easier to look at the output manually if need be. To be 100% correct, yeah this would require either a change of the format s.t. the names aren't used directly and they're stored in another table, but I'm hesitant to go for that. I'm pretty sure one of the iterations used that approach (perhaps sfpv as I built tables to llvm::clang::someOtherNamespace::Function pointers rather than using the stringified names in parts of the code) and debugging issues with that was a giant pain.

from stoat.

dsacre avatar dsacre commented on July 25, 2024

In boost's defense, map<string, vector<string>> alone is around 250 characters when fully spelled out. The function actually takes two of those, and each argument appears (only) twice in the type signature... :)

Does this look ok to you?
dsacre/stoat@de21782

I take it the shortened names only affect what would appear in the output/graph, and stoat uses mangled names for everything else?

from stoat.

fundamental avatar fundamental commented on July 25, 2024

That might be sufficient in practice as llvm does replace lengthy templated type names with shorter versions, but it might make sense to just limit some of the other printfs to this limit (when they're getting used as keys).

Shortened names should only show up in the graphviz renderings, though they're also used in pattern matching for the white/black lists. They can't be used at the YAML file level as collisions happen too easily.

from stoat.

dsacre avatar dsacre commented on July 25, 2024

Here's a more complete patch. Is this what you had in mind?
dsacre/stoat@e9b527a

from stoat.

fundamental avatar fundamental commented on July 25, 2024

Yeah that looks right. I'll try to merge that in this afternoon.

from stoat.

fundamental avatar fundamental commented on July 25, 2024

Merged. I've also added you to the contributor list on github, so you should have commit access as well. thanks 👍

from stoat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.