[Proposal]: uniq about toolbox

[hamed-bavar]

I think JSON.stringify is not the best choice for deeply comparing two objects, It is not going to work as expected for function and symbol types and some others, so it will have different behavior for different types of objects and you should have different strategy based on types of objects. I think using === is better because it will always return false for objects that do not have the same reference.

[hamed-bavar]

in my opinion uniqBy comes very handy, but uniq and uniqWith can be implemented in just one function (for default using shallow comparison otherwise using a provided comparison function).

[hamed-bavar]

How should elements be compared with each other? through deep comparison or just by reference?

[mahdi-sheibak]

see this example: https://codesandbox.io/p/sandbox/uniq-example-czqq98
@hamed-bavar @ASafaeirad

[mahdi-sheibak]

please share a sandbox

[hamed-bavar]

check this out. https://playcode.io/1562822

[mahdi-sheibak]

This is good, but does not work on an array of objects. How we can provide this on your implementation?

anotherImplementation([
    {name:"John"},
    {name:"John"},
])

[hamed-bavar]

I know, as I said this implementation is just a shallow comparison (===) for the sake of keeping everything simple and performant [just like uniq function in lodash]. For deep comparison you need more than that, just a JSON.stringify. the uniq function should be prepared for comparing functions, dates, Symbols, complex nested objects, etc which makes the function very messy and slow.

[hamed-bavar]

@ASafaeirad, @mahdi-sheibak. what if we shallow compare by default unless a comparison function was provided. but the time complexity would be more than previous implementation since the compare function of sets in JavaScript can not be changed and we need to use array instead.

[mahdi-sheibak]

I know, as I said this implementation is just a shallow comparison (===) for the sake of keeping everything simple and performant [just like uniq function in lodash]. For deep comparison you need more than that, just a JSON.stringify. the uniq function should be prepared for comparing functions, dates, Symbols, complex nested objects, etc which makes the function very messy and slow.

I completely agree with you! How about we take inspiration from lodashjs and create three useful functions: 'uniq' to filter out duplicate values, 'uniqBy' to filter duplicates by a specific key, and 'uniqWith' to filter duplicates based on custom comparison logic?

[ASafaeirad]

Agree, two objects with different references are not considered the same in the language therefore, to follow the "Least Surprise" principle, the uniq function should not mark them as duplicates. let's keep it simple and compare it with Object.is

[github-actions]

🎉 This issue has been resolved in version 4.5.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀