Bitcode is not enabled for real device iOS builds about react-native-firestack

[auser]

Hein,

Thanks for the note. You're the second to ask for this (thanks for making the issue). I disabled it previously as bit-code caused a build error previously. I don't recall the specific reason why I had it disabled, but I will investigate and report back.

[IjzerenHein]

Awesome! If I can be of any assistance let know.
Cheers, Hein

[IjzerenHein]

Btw, quick other question. I've integrated Firebase Crash reporting in my App. Complete with console.log interception and correct callstacks (both iOS and Android). Would you be interested in having this code to the firestack codebase?

[auser]

Hein,

Absolutely! I've been meaning to put that on the feature list!
I have an initial doc on describing how it all works (https://github.com/fullstackreact/react-native-firestack/blob/master/Contributing.md). I think making it another module (akin to database, analytics, etc) makes the most sense that perhaps we can enable through a config setting.

What do you think?

[IjzerenHein]

Alright cool. It's really busy at the moment, but I'll try to create a pull request for it anytime soon.

[auser]

Hein,

Let me know if you want some help on how to integrate it.

[IjzerenHein]

Yeah, well most of it is pretty straightforward to integrate. The only tricky thing is that when building the bundle, it also needs to generate sourcemaps. I've modified my scripts for it, but not sure how that would need to be done automatically when installing the firestack lib (or using react-native link). I'll have a closer look when I have more time.

[IjzerenHein]

And yeah, having it in a separate module such as crash would definitely also make sense to me. 👍

[IjzerenHein]

Btw, I was using the storage API's today and noticed the examples in the README are out of date.
It says firestack.uploadFile but it should be firestack.storage.uploadFile. But you're probably already aware of this :)

It works great btw =)

[auser]

Oh yes! Can you make a PR with that update?

You can even make it by editing the README using the github editor (I believe through the site).

[auser]

Okay, I recall why bit-code needed to be disabled. Firestack is built as a dynamic library, which needs to be linked against static libraries (React). Until we find a way to dynamically link Firestack to React, we can't enable bitcode.

Any suggestions?

[auser]

As of now, I can't enable bitcode due:

1. bitcode and the undefined flag are opposites (for obvious reasons, but we cannot build a library that cannot find it's symbols, but cannot build a dynamic library without using -undefined flag (yet).
2. Setting the build to a static library does not allow our app to find the Firebase libraries
3. Setting the build to a dynamic library does not allow our app to use bitcode

I'm going to mark this as wontfix for now, until we can figure out a different build mechanism.

[auser]

I think I fixed the bitcode issue. I pushed the latest update to the feature/bitcode branch, if you're interested in trying it out in your app.

Nevermind.

This is a pretty good reason for now using bitcode. Not necessarily that I agree that we shouldn't enable bitcode... For the time being, I'm okay with it being a requirement.