Coder Social home page Coder Social logo

Comments (5)

petertonysmith94 avatar petertonysmith94 commented on September 26, 2024 1

Summary

  • Docs-hub pulls over our raw assets (.md and .test.ts), parses, and builds them.
  • I've identified probable issues and tested their solutions (see below).
  • Maintaining two documentations systems seems obsolete to me.

Investigation

  1. Sometimes code snippets are malformatted (indentation)
    https://docs.fuel.network/docs/nightly/fuels-ts/providers/

Occurs during the fix-indent.ts process on the docs hub. Also appears to be a problem with the rust snippets.
https://docs.fuel.network/docs/nightly/fuels-rs/deploying/configurable-constants/
https://docs.fuel.network/docs/nightly/fuels-rs/predicates/send-spend-predicate/

I believe this is due to regex replacement conflicting. For all projects, languages and coding format.

  • Simplify and separate this regex replacement by project + language, should alleviate this issue and lead to more predictable results.

  1. Sometimes code snippets don't have syntax highlight

There is no syntax highlighting configured for html or html-vue in the docs hub.

  • The code snippet language changed from html-vue to html.
  • Add html to the highlighter langs in the docs-hub.

After


  1. Sometimes code snippets have "import" comments

Incorrect #import format. Should be: // #import { BN, CoinQuantityLike, ScriptTransactionRequest };

  • Additional lint checking within fuels-ts.

  1. Variables are not getting rendered

Variables not being detected. Potential solution:

  • Changing equality check to includes on the conditions.
  tsBookVersions: (node: any) => {
    return (
      typeof node.value === 'string' &&
      (node.value.includes('{{fuels}}') ||
        node.value.includes('{{fuelCore}}') ||
        node.value.includes('{{forc}}')
      )
    );
  },
  • Alter the node value directly before any other manipulation.
  visit(newTree, '', (node: any, idx, parent) => {
    if (conditions.tsBookVersions(node)) {
      node.value = node.value
        .replace('{{fuels}}', versions.FUELS)
        .replace('{{fuelCore}}', versions.FUEL_CORE)
        .replace('{{forc}}', versions.FORC);
    }
    ...
  })

  1. Button "see code in context" doesn't work on the docs portal
  • I believe this is a feature request within the docs-hub?

Side quest: We should probably be considering getting rid of #context tags if possible.

There are 54 instances of#context, 45+ should be pretty simple. Would be good to get people's ideas on the import, as I can't see a way to do it currently.
https://github.com/FuelLabs/fuels-ts/blob/master/apps/demo-typegen/src/demo.test.ts#L79

from fuels-ts.

petertonysmith94 avatar petertonysmith94 commented on September 26, 2024 1

That sounds like a better idea 🥇

from fuels-ts.

petertonysmith94 avatar petertonysmith94 commented on September 26, 2024 1

Closing due to all issues within fuels-ts being resolved and associated docs-hub issues have been created.

from fuels-ts.

petertonysmith94 avatar petertonysmith94 commented on September 26, 2024

Moving this back to Queued and setting to blocked as awaiting docs-hub related work.

Keeping my name on for follow up purposes 😄

from fuels-ts.

arboleya avatar arboleya commented on September 26, 2024

Great job! Can't we close the issue as completed? 🙂

You did everything and created issues on the docs-hub repo for the remaining items.

from fuels-ts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.