Error for decode erros in contract about fuels-ts

[petertonysmith94]

Hey @luisburigo, hope you are well.

I have been playing around with your example (thank you btw), not 100% on the root cause just yet. I did find a potential workaround (hopefully it can unblock you).

abi ContractA {
  fn method(contract_b_id: ContractId);
}

impl ContractA for Contract {
  fn method(contract_b_id: ContractId) {
    let contract_b = abi(ContractB, contract_b_id.into());
    let result = contract_b.method();
  }
}

With the expected result of:

return new RequireRevertError(receipt, reason);
             ^
RequireRevertError: The script reverted with reason RequireFailed

[arboleya]

The issue is that we need the ABI of all contracts before being able to decode their logs. One suggested solution would be to, in case the ABI is missing and we can't decode logs, to just print a warning and move on instead of throwing.

This is subject to further analysis, of course.

[nedsalk]

@luisburigo I just took a look at your code and you didn't add contract B into the call so the library doesn't know how to decode it. You should do this:

    const contractAAbi = ContractAAbi__factory.connect(contractA, wallet);
    const contractBAbi = ContractBAbi__factory.connect(contractB, wallet);
    const result = await contractAAbi.functions.method({
        value: contractB
    })
    .addContracts([contractBAbi]) //  <------- this was missing
    .txParams({
        gasPrice: 1,
        gasLimit: 1_000_000,
    })

[arboleya]

Can we close this?

[luisburigo]

Repository to reproduce the error: https://github.com/luisburigo/fuel-ts-issue.git

[luisburigo]

I debugged the code and found the error in this function:

fuels-ts/packages/account/src/providers/transaction-response/getDecodedLogs.ts

Lines 8 to 22 in 116d642

	export function getDecodedLogs<T = unknown>(
	receipts: Array<TransactionResultReceipt>,
	abiInterface: Interface
	): T[] {
	return receipts.reduce((logs: T[], r) => {
	if (r.type === ReceiptType.LogData) {
	logs.push(abiInterface.decodeLog(r.data, r.val1.toNumber(), r.id)[0]);
	}
	if (r.type === ReceiptType.Log) {
	logs.push(abiInterface.decodeLog(new U64Coder().encode(r.val0), r.val1.toNumber(), r.id)[0]);
	}
	return logs;
	}, []);

[luisburigo]

Hey, @petertonysmith94 @arboleya thanks for the response.

This code in the description is just an example. In my contracts, I use the correct abi.

In this repo https://github.com/luisburigo/fuel-ts-issue there is an example of this bug.

[petertonysmith94]

@luisburigo I just took a look at your code and you didn't add contract B into the call so the library doesn't know how to decode it. You should do this:

    const contractAAbi = ContractAAbi__factory.connect(contractA, wallet);
    const contractBAbi = ContractBAbi__factory.connect(contractB, wallet);
    const result = await contractAAbi.functions.method({
        value: contractB
    })
    .addContracts([contractBAbi]) //  <------- this was missing
    .txParams({
        gasPrice: 1,
        gasLimit: 1_000_000,
    })

Look at that, thanks for the share ❤️

Link to the documentation on inter-contract calls.

[luisburigo]

@luisburigo I just took a look at your code and you didn't add contract B into the call so the library doesn't know how to decode it. You should do this:

    const contractAAbi = ContractAAbi__factory.connect(contractA, wallet);
    const contractBAbi = ContractBAbi__factory.connect(contractB, wallet);
    const result = await contractAAbi.functions.method({
        value: contractB
    })
    .addContracts([contractBAbi]) //  <------- this was missing
    .txParams({
        gasPrice: 1,
        gasLimit: 1_000_000,
    })

Look at that, thanks for the share ❤️

Link to the documentation on inter-contract calls.

Thanks @petertonysmith94 ❤️❤️