Comments (8)
@arboleya @Dhaiwat10 I reckon this issue is blocked by FuelLabs/fuel-vm#691
It seems the plan to implement this is only after mainnet.
from fuels-ts.
Related (same?):
from fuels-ts.
Does this still need to be fixed after #1767 ?
from fuels-ts.
@Dhaiwat10 If I am not mistaken, for this one we are waiting for a possible update on fuel-core
that will include on the dryRun
response the amount of OutputVariables
required by a TX when calling dryRun
.
from fuels-ts.
@Torres-ssf Did we communicate this need to someone?
Ideally, we should mark this issue as blocked and add a link here to another issue on the fuel-core
repo.
from fuels-ts.
That was the missing issue, then.
Thanks for pointing that out.
from fuels-ts.
Based on the issue's proposed changes (specifically "Discontinue automatic addition of OutputVariable
"), this doesn't seem like blocked. This issue is concerned with not running transaction dependency estimation by default anymore, whereas the linked fuel-vm issue - if I understood it correctly - is concerned with getting all the dependencies in one call instead of requiring multiple calls:
The FuelVM may support dry run mode, in which all validity rules will not abort the execution immediately. Instead, we will keep a record of what rules are failing and provide feedback at the end of the execution with all problems.
We can already make dependency estimation and opt-in thing, it'd just break the apps of our consumers that didn't specify the appropriate outputs.
from fuels-ts.
@nedsalk This is blocked.
The desired behavior, as outlined in this issue, is for the dry-run to indicate the number of variable outputs required for the transaction to be processed.
Implementing this feature will eliminate the need for multiple dry-runs to determine the necessary outputs.
We cannot expect users to always provide the correct number of variable outputs, especially for complex transactions involving multiple parties ( wallet connectors ).
from fuels-ts.
Related Issues (20)
- Implement contract testing in `create fuels` HOT 1
- Investigate Why Test Files Are Being Ignored By Lint Script HOT 2
- Check for Blobs' existence before uploading them
- Abi - Refactor / Kickoff HOT 3
- Abi - Refactor / Parser
- Abi - Refactor / Coder
- Abi - Refactor / Gen HOT 1
- Abi - Refactor / Conclusion
- Typedoc secondary entrypoints rendered on the docs hub HOT 6
- Typegen producing inconsistent outputs between runs
- Add basic infra for benchmarks HOT 1
- Document Error for Failed Transaction Resubmission Due to Spent Resources HOT 2
- Upgrade to `[email protected]`
- Error on contract call forwarding an assetId different from base assetId HOT 3
- Upgrade to forc `0.63.3`
- Consider moving `ApiDocs` outside of the documentation.
- Improve DX for storage slots deployment
- remove u64 from NumberCoderType Union
- `UtxoIdCoder` output index should be `u16`
- Increase test timeout to reduce flakiness HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fuels-ts.