Comments (12)
Wouldn't mind giving a try at the issue.
from nope-validator.
Sure thing!
Assigned the issue to you!
Thanks for contributing!
from nope-validator.
Is it fine if I make a branch or should I fork the repo?
And happy to help! First time with TypeScript so it might take me a little bit to get used to typed JavaScript :)
from nope-validator.
I'd prefer if you'd fork the repo!
If you get stuck on something feel free to ask!
from nope-validator.
+1
from nope-validator.
For the #resolveNopeRef()
method, would it be fine to make it a private class-level method since both #oneOf()
and #notOneOf()
would be using it?
from nope-validator.
It sure does, but I'm afraid if we put it in the Primitive
class that time will come when we'll have more complex classes that don't extend the class Primitive
- that's why I made it a util
from nope-validator.
Sounds good!
from nope-validator.
As a heads-up, gonna head out to work. The implementation is done and I wrote a couple of unit tests for it so far. I'll go ahead and wrap up the tests tonight (or later today if I can find the free time) and create a PR for it.
from nope-validator.
Awesome man, thanks a lot! have a great day t work
from nope-validator.
Let me know if anything needs to be fixed
from nope-validator.
Thanks for your contribution! Closing this issue since its implemented
from nope-validator.
Related Issues (20)
- required HOT 1
- No validation on nested schema/data HOT 3
- Security Issue: Request for contact HOT 2
- Add async validation
- Add option to report all errors related to a field, not just the first one
- Missing `array` validator type HOT 4
- [Suggestion] add benchmark action to comment on each PR HOT 1
- utils.ts: every HOT 1
- Doesn't seem to be functioning identically to `yup` HOT 2
- Phone Validator HOT 2
- Add default option HOT 1
- Add validateAt and validateAtSync HOT 1
- Using ref with primitive methods
- shape() validation crash on undefined HOT 2
- .trim() functionality HOT 8
- .trim() bug if using as a resolver for react-hook-form HOT 5
- Validate array of objects HOT 1
- 🛠 nope-validator v2.0.0 HOT 1
- Cannot use with ES modules due to package.json
- Nested Object validation doesn't allow for undefined field HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nope-validator.