Coder Social home page Coder Social logo

Breaks form submit about fastclick HOT 7 CLOSED

ftlabs avatar ftlabs commented on July 24, 2024
Breaks form submit

from fastclick.

Comments (7)

samgiles avatar samgiles commented on July 24, 2024

Confirmed in iOS6 (emulator at least). Added test case.

from fastclick.

 avatar commented on July 24, 2024

I am noticing after the fix above, that I have to hit the enter key twice in the ios6 emulator for it to submit.

from fastclick.

samgiles avatar samgiles commented on July 24, 2024

I can't reproduce that, I only have to hit enter once in iOS6 emulator (iPad and iPhone): http://ftlabs.github.com/fastclick/tests/18.html

from fastclick.

 avatar commented on July 24, 2024

Ah, your test is including version 0.3.0, while on my side I am including 0.3.2 (https://raw.github.com/ftlabs/fastclick/master/lib/fastclick.js). Please update your test with the newest version and you will reproduce the double enter issue.

from fastclick.

mattcg avatar mattcg commented on July 24, 2024

OK, I've updated the public pages so that the test loads 0.3.2 and I can reproduce the issue.

from fastclick.

mattcg avatar mattcg commented on July 24, 2024

Should be fixed. It seems when the enter key is hit on a hard keyboard or the Go button on the soft keyboard is tapped then a 'fake' click event will be dispatched, by Safari itself, to the submit-type input element (if one is present) and if preventDefault is called on this click event then the form will not be submitted.

from fastclick.

 avatar commented on July 24, 2024

Confirmed, 0.3.3 fixed my issue with double enter. Thanks

from fastclick.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.