I have tried to simply some of the code, have a look. about sneakpeek

[NoahSee]

I cant really do a pull request because, ive used mongodb as the database.

[fterh]

Hi, thanks for your effort! Could you quickly walk us through the main enhancements you made?

[NoahSee]

I have made the functions in main.py do returns rather than call other functions so that it reads more easily.

1. In your code, main.py does not tell you the overall flow, because scan(subreddit) calls a function that calls yet another function. I made it such that submission.reply () can be seen on main.py. Hence you can see the whole flow on what the code is doing.

2. Ive used MongoDB Atlas because its much easier for me to run. Notice that it is cloud based and needs much less code to work. A collection in MongoDB is simply a list of dictionaries. Ive used a method to return the whole list to check through so it only needs to be read once each time main.py runs.

if any( submission_record['submission_id'] == submission.id for submission_record in submission_records):

does all the work of checking if the submission has already been processed, so you dont need to use qualify()

3. process_submission.py (WIP) should return a comment if url is valid or None if url is not valid. Im currently testing using straitstimes only.

4. Im currently looking into deploying it on AWS Lambda, but it has a bunch of issues with the external libraries.

5. You can easily implement the logging function im using if you need it.

[NoahSee]

Update: code is operational on lambda.

[fterh]

@NoahSee Hi, are you running /u/AngryAngryCat?

[NoahSee]

Yes. Ive been letting it run since last night.

…

On Wed, 6 Feb 2019, 9:21 pm Fabian Terh, ***@***.***> wrote: @NoahSee <https://github.com/NoahSee> Hi, are you running /u/AngryAngryCat? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQVbDEygKp0D7nT_ri8ZSxEOIEed79BOks5vKtbZgaJpZM4agBqv> .

[fterh]

Can I confirm if you will be running it long-term? I understand that you're running it on a modified codebase (based off this one). I'm just not sure how we're going to coordinate future releases, since I (and the other collaborators) will be working on this repo in the future, and your repo isn't a fork off this so you can't do a git pull.

[fterh]

Also, thanks for your breakdown of the changes you've made. I haven't had time to look into that in detail, but I'll definitely get back to that when my schedule clears up. :)

[NoahSee]

Im still looking at recoding the handlers to make them more modular and thus more open sourcable. Think fn(url). I can walk you through the lambda / mongodb deployent sometime. The actual web scraping might be too much work for me. Im quite happy as long as it works for st premium. Can you explain why @classmethod is used so extensively?

…

On Wed, 6 Feb 2019, 9:30 pm Fabian Terh, ***@***.***> wrote: Can I confirm if you will be running it long-term? I understand that you're running it on a modified codebase (based off this one). I'm just not sure how we're going to coordinate future releases, since I (and the other collaborators) will be working on this repo in the future, and your repo isn't a fork off this so you can't do a git pull. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQVbDNN_cfFLtD_R-XMJd59QBQjpMUqOks5vKtjugaJpZM4agBqv> .

[NoahSee]

I have updated the handlers. Have a look.

https://github.com/NoahSee/reddit_commenter

You can coordinate the open sourcing on your repo. I will update the handlers on my repo every once a while. I dont think there needs to be 2 bots running in the long run. Im testing mine for now and ill delete duplicate posts on my end if I see any.

Are you interested in running my version of the code? It uses free tier AWS and mongodb and theres no system infrastructure to mange.

[fterh]

I'd prefer to run on my codebase at the moment, although I'm definitely interested to see how I can further improve it once I have time to look at your changes :)

I'm also definitely interested to run on a platform like lambda so I don't have to manage infrastructure. I considered mongodb atlas, but I dropped it because I wanted to get my beta up and running as quickly as I can, and sqlite3 seemed robust enough. It does sound like a great milestone for a future release though!

[NoahSee]

Cool. Let me know if you have any questions.

[xlanor]

For the bot I dont think you need to deploy it on atlas. I think running it off a local instance on your DO droplet might be more than sufficient.

[yleong]

I agree that a DO droplet can more than handle this workload. But I like the idea of fn(url). That way anybody can call the code. Deploying on AWS can solve the uptime issues too.

However, since reddit_commenter has no shared git history with sneakpeek, any merge might have to be copied out-of-band. @NoahSee , what license are you releasing reddit_commenter under?

[NoahSee]

I havent added a licence. You can use whatever you need since most of the code is yours to begin with.

[NoahSee]

Hi guys,

I will not be doing any more updates on my repo. It was a good project to do over the CNY break, I really wanted to try out your code and see how I could improve on it.

Also, my bot account got banned. lol