DriverStation & RobotController Sanity Checks about ftc_app

[rwoodley]

I don't think we should introduce more ways for WiFi pairing to fail silently. Sanity check failures could be logged, but should not result in WiFi errors.

[AlecHub]

If there is a newline character in the WiFi-Direct name, then it crashes other teams' phones. In this case, the RC should not create a WiFi Direct group, and the DS should not attempt to pair with any RCs, if either of their respective names has a newline character.

Agree with @rwoodley that other sanity checks can be logged instead of fail if by "logged" you mean a big "red alert" indication in the GUI; not just some message buried in the logcat.

[strugee]

@rwoodley so don't fail silently. Fail loudly, and with lots of error dialogs.

[magneticflux-]

@strugee The problem is, it shouldn't bug people when other people's malformed names try to connect. It should hide the error on the receiving end, and show it on the sending end. No problem finding the error if both phones are from one team, but other people can't be malicious with the system.

[gearsincorg]

Closed, as this issue relates to previous season code.
Current season includes built-in inspection tool & optional name filtering.