unique overload for CircularBuffer method 'Enqueue' could not be determined about fsharpx.collections

[vasily-kirichenko]

VS 15.7.4

Everything compiles OK and the tests pass (build.cmd).
Also, everything compiles OK from within VS.
But the editor does not work on the test project:

Error | FS3160 | Problem reading assembly 'C:\git\FSharpx.Collections\src\FSharpx.Collections\bin\Debug\net45\FSharpx.Collections.dll': Build was not evaluated, expected the results to be ready after 'Eval' (GetCheckResultsAndImplementationsForProject, data = ("FinalizeTypeCheck", [|Id 1007; Id 1008; Id 1009; Id 1010; Id 1011|], Id 1013, false, None)). | FSharpx.Collections.Tests | C:\git\FSharpx.Collections\tests\FSharpx.Collections.Tests\CircularBufferTests.fs | 1 | Active

[vasily-kirichenko]

Rider 2018.2 works totally OK:

[jackfoxy]

As discussed on Slack, the problem is revealed in the tests that are commented (because they do not build).

[jackfoxy]

With @vasily-kirichenko help on the https://functionalprogramming.slack.com/messages/C045LHLTH/ channel we figured out the problem. I'm sure this is an old regression that the compiler no longer takes into account overload ordering, so it cannot tell the difference between 'T [] and 'T.

[jackfoxy]

Work around is to specify type parameter, e.g. let circularBuffer = CircularBuffer<int> 5

[jackfoxy]

Not a bug in compiler. Old 2013 was exploiting a prior bug in compiler which has been fixed.