Comments (16)
when is this realistic to land? we have a need for it but would implement on our own otherwise.
from excelfinancialfunctions.
Hi @vanthome, I think FSharp.Core should work already with .NET core, that's basically what was needed (+project configuration). Unfortunately I cannot test it on Windows, so would be great if you could try that out.
from excelfinancialfunctions.
Yes, I also read that .net core is now F# ready.
I'm also not using Wondows ;)
My Problem is I want to use the project as a dependency in a netcore app.
When I try to restore after adding it, I get this:
error: Package ExcelFinancialFunctions 2.3.1 is not compatible with netcoreapp1.0 (.NETCoreApp,Version=v1.0). Package ExcelFinancialFunctions 2.3.1 supports:
error: - net40 (.NETFramework,Version=v4.0)
error: - portable-net45+win8+wp8+wpa81 (.NETPortable,Version=v0.0,Profile=Profile259)
error: Package FSharp.Core 4.0.0.1 is not compatible with netcoreapp1.0 (.NETCoreApp,Version=v1.0). Package FSharp.Core 4.0.0.1 supports:
error: - net20 (.NETFramework,Version=v2.0)
error: - net40 (.NETFramework,Version=v4.0)
error: - portable-monoandroid10+monotouch10+net45+xamarinios10 (.NETPortable,Version=v0.0,Profile=net45+monoandroid10+monotouch10+xamarinios10)
error: - portable-net45+sl5+win8 (.NETPortable,Version=v0.0,Profile=Profile47)
error: - portable-net45+win8 (.NETPortable,Version=v0.0,Profile=Profile7)
error: - portable-net45+win8+wp8 (.NETPortable,Version=v0.0,Profile=Profile78)
error: - portable-net45+win8+wp8+wpa81 (.NETPortable,Version=v0.0,Profile=Profile259)
error: One or more packages are incompatible with .NETCoreApp,Version=v1.0.
Then I tried to import net40 to make it happy like this:
"frameworks": {
"netcoreapp1.0": {
"imports": [
"net40"
]
}
},
But then it silently just not installs ExcelFinancialFunctions
So how can the package be made compatible with netcore?
from excelfinancialfunctions.
AFAIK it should be enough to convert this project to be a portable component targeting profile 259 (rather than profile 7). https://github.com/fsprojects/ExcelFinancialFunctions/blob/master/src/ExcelFinancialFunctions/ExcelFinancialFunctions.Portable.fsproj
from excelfinancialfunctions.
Hmm that sounds darn easy. As I'm using VS Code, it's probably better someone with VS is doing this. Also the project needs to be published to Nuget again.
from excelfinancialfunctions.
@vanthome You don't need to use VS to do this - just change the profile number, rebuild and see what happens.
from excelfinancialfunctions.
@dsyme that seemed to help but it failes with:
/temp3/ExcelFinancialFunctions/ExcelFinancialFunctions.sln (Rebuild) ->
(Rebuild target) ->
/temp3/ExcelFinancialFunctions/src/ExcelFinancialFunctions/ExcelFinancialFunctions.fsproj (Rebuild) ->
/temp3/ExcelFinancialFunctions/src/ExcelFinancialFunctions/ExcelFinancialFunctions.fsproj: error : Target named 'Rebuild' not found in the project.
/temp3/ExcelFinancialFunctions/ExcelFinancialFunctions.sln (Rebuild) ->
(Rebuild target) ->
/temp3/ExcelFinancialFunctions/tests/ExcelFinancialFunctions.Tests/ExcelFinancialFunctions.Tests.fsproj: error : /temp3/ExcelFinancialFunctions/tests/ExcelFinancialFunctions.Tests/ExcelFinancialFunctions.Tests.fsproj: The required attribute "Project" in Import is empty
/temp3/ExcelFinancialFunctions/src/ExcelFinancialFunctions/ExcelFinancialFunctions.Portable.fsproj: error : /temp3/ExcelFinancialFunctions/src/ExcelFinancialFunctions/ExcelFinancialFunctions.Portable.fsproj: /temp3/ExcelFinancialFunctions/src/ExcelFinancialFunctions/ExcelFinancialFunctions.Portable.fsproj could not import "$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\FSharp\Microsoft.Portable.FSharp.Targets"
from excelfinancialfunctions.
See this PR: #12
from excelfinancialfunctions.
Merged
@luajalla @cpell Can you publish the updated nuget package?
@vanthome Could you try it out?
from excelfinancialfunctions.
@vanthome, please try with the latest package (v2.4).
from excelfinancialfunctions.
Unfortunately I get the same error as with the version before:
error: Package ExcelFinancialFunctions 2.4.0 is not compatible with netcoreapp1.0 (.NETCoreApp,Version=v1.0). Package ExcelFinancialFunctions 2.4.0 supports: portable-net45+win8+wp8+wpa81 (.NETPortable,Version=v0.0,Profile=Profile259)
error: Package FSharp.Core 4.0.0.1 is not compatible with netcoreapp1.0 (.NETCoreApp,Version=v1.0). Package FSharp.Core 4.0.0.1 supports:
error: - net20 (.NETFramework,Version=v2.0)
error: - net40 (.NETFramework,Version=v4.0)
error: - portable-monoandroid10+monotouch10+net45+xamarinios10 (.NETPortable,Version=v0.0,Profile=net45+monoandroid10+monotouch10+xamarinios10)
error: - portable-net45+sl5+win8 (.NETPortable,Version=v0.0,Profile=Profile47)
error: - portable-net45+win8 (.NETPortable,Version=v0.0,Profile=Profile7)
error: - portable-net45+win8+wp8 (.NETPortable,Version=v0.0,Profile=Profile78)
error: - portable-net45+win8+wp8+wpa81 (.NETPortable,Version=v0.0,Profile=Profile259)
error: One or more packages are incompatible with .NETCoreApp,Version=v1.0.
from excelfinancialfunctions.
I want to get this project to build in VS2017, will you be willing to accept a Pull Request?
It seems you prefer to use paket rather than nuget. How do I get the two to work harmoniously?
I am also new to the F# world, and I know you take the cross platform story very seriously. Any other pitfalls you think I should watch out for?
from excelfinancialfunctions.
Is there any update on this issue?
If not, I can create a PR to do so with some help
from excelfinancialfunctions.
Please do, that would be great!
from excelfinancialfunctions.
Now runs on .NET Core. Would love to hear any issues or concerns anyone finds.
from excelfinancialfunctions.
Nice!
from excelfinancialfunctions.
Related Issues (20)
- ExcelFinancialFuctions equivalent for Percentile.Inc HOT 2
- Generating Documentation HOT 7
- Compilation error on local machine HOT 3
- C# .NET Core Port HOT 4
- FSharp.Core 4.3.4 Nuget update HOT 3
- Behavior of AccrInt does not match Excel when firstInterest <= settlement HOT 4
- Call for maintainers HOT 4
- Compile project HOT 1
- Find Root operation does not follow Excel spec as stated in comment => common.fs HOT 2
- The interaction of Bisection and Newton algo in findRoot needs review HOT 5
- Disable unstable test: mduration shouldn't be greater than maturity()
- Release 3.0.0-rc1 HOT 10
- Release 3.0.1 HOT 7
- GitHub pages are not working? HOT 3
- Implement CAGR/RRI HOT 2
- Release 3.0.0 HOT 1
- Implement PDURATION
- Release 3.1.0 HOT 2
- Release 3.2.0
- Release 3.3.0
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from excelfinancialfunctions.