Coder Social home page Coder Social logo

Comments (6)

jhulten avatar jhulten commented on April 28, 2024

+1

Taking a channel allows the caller to specify it is done by closing the channel. Thoughts @fsouza?

I am willing to take a swing at this.

from go-dockerclient.

fsouza avatar fsouza commented on April 28, 2024

@jhulten the reader should never close the channel.

I imagine that Events(since uint64) could create a goroutine and write the output to a channel that it returns. Something like:

ch := make(chan type, size)
go func() {
  for _, event := range events {
     ch <- event
  }
  close(ch)
}()
return ch

What do you think?

from go-dockerclient.

jhulten avatar jhulten commented on April 28, 2024

I put a stake in the ground with #71. I will look at changing it to return a channel tomorrow.

from go-dockerclient.

fsouza avatar fsouza commented on April 28, 2024

Thank you, I will have a look within the next hours :)

from go-dockerclient.

destari avatar destari commented on April 28, 2024

Should this be closed now?

from go-dockerclient.

fsouza avatar fsouza commented on April 28, 2024

Sure. Thanks!

from go-dockerclient.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.