client: implement BuildImage about go-dockerclient

[xh3b4sd]

I am a bit confused about that. Currently I try to build an image using the go client that uses the method ImportImage and references to api docs. That issue says to building an image needs to be implemented. Further the link referenced in that issue is not working as expected.

As I understand it correctly I need to do the following in the current state of the go client:

• checkout an repository containing a Dockerfile (for example)
• create an archive of that repository (.tar)
• call the clients ImportImage method giving it the previously create archive as url or string content

If I would understand that correctly and have implemented it, I would like to create better documentations in form of a pull request. So, maybe someone can tell me in detail if I am right with my assumptions.

[fsouza]

@zyndiecate the BuildImage method creates an image from a Dockerfile, while the ImportImage method creates an image from a tar ball.

There's a /build action in the Docker API, unfortunately the link in the description of the issue is broken: http://docs.docker.io/en/latest/api/docker_remote_api_v1.8/#build-an-image-from-dockerfile-via-stdin.

So, ImportImage is the same as docker import (from the command line), while BuildImage is the same as docker build.

[fsouza]

I've fixed the link in the issue description.

[xh3b4sd]

Ok, cool. I will try to get building images using the remote API to work. My approach in theory would be:

1. fetching a tarball using a stream
2. dispatch that stream to c.stream as the input io.Reader
3. 🍰

Will see if that works in go as I imagine. Downloading to the filesystem would be bad. May you have any suggestions @fsouza ?

[xh3b4sd]

That issue is now partially solved.

[fsouza]

Thanks @zyndiecate! :)

[fsouza]

We now need to fix the second case: when the client already have the content of the tar file, and pass that to the method using an io.Reader.

[fsouza]

It's now fixed.