Coder Social home page Coder Social logo

Newsletter about frontity.org HOT 7 CLOSED

frontity avatar frontity commented on August 11, 2024 2
Newsletter

from frontity.org.

Comments (7)

SantosGuillamot avatar SantosGuillamot commented on August 11, 2024 1

Yes, I agree that the placeholders and the Privacy Policy shouldn't change. Regarding the layout, I'd prefer using classes, it looks clearer to me.

from frontity.org.

SantosGuillamot avatar SantosGuillamot commented on August 11, 2024

I'm blocking it until we have the design of the checkbox.

from frontity.org.

luisherranz avatar luisherranz commented on August 11, 2024

Thanks Mario. Could you please specify the Gutenberg inner blocks that will be used for the editable content?

from frontity.org.

SantosGuillamot avatar SantosGuillamot commented on August 11, 2024

Oh yes, I forgot to post that sorry. I've updated the opening post.

from frontity.org.

SantosGuillamot avatar SantosGuillamot commented on August 11, 2024

The designer has updated this, so I'm unblocking the issue.

from frontity.org.

luisherranz avatar luisherranz commented on August 11, 2024

Thanks Mario.

Some feedback about the editable content:

  • I don't think placeholders are necessary, they are not going to change.
  • I don't think the Privacy Policy is necessary, it is not going to change.
  • The title, description and thank-you message are fine, but it's going to be hard to retrieve from the HTML with that layout. It's easier if that information is in the node itself. For example:
    • Using classes:
      <p class="title">Join the Frontity newsletter</p>
      <p class="description">Stay up-to-date on new releases and features, tutorials, and community news.</p>
      <p class="thank-you">Thank you! You have been subscribed to the Frontity newsletter. You will receive a welcome email shortly.</p>
    • Using children order (1st title, 2nd desc, 3rd thank-you):
      <p>Join the Frontity newsletter</p>
      <p>Stay up-to-date on new releases and features, tutorials, and community news.</p>
      <p>Thank you! You have been subscribed to the Frontity newsletter. You will receive a welcome email shortly.</p>

from frontity.org.

SantosGuillamot avatar SantosGuillamot commented on August 11, 2024

In order to test if the logic of the old implementation could work, and check the best way to connect Gutenberg and React, I created this draft Pull Request #75 . It works so I guess the migration is possible. I share it in case it's useful as an starting point.

from frontity.org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.