Comments (7)
Yes, I agree that the placeholders and the Privacy Policy shouldn't change. Regarding the layout, I'd prefer using classes, it looks clearer to me.
from frontity.org.
I'm blocking it until we have the design of the checkbox.
from frontity.org.
Thanks Mario. Could you please specify the Gutenberg inner blocks that will be used for the editable content?
from frontity.org.
Oh yes, I forgot to post that sorry. I've updated the opening post.
from frontity.org.
The designer has updated this, so I'm unblocking the issue.
from frontity.org.
Thanks Mario.
Some feedback about the editable content:
- I don't think placeholders are necessary, they are not going to change.
- I don't think the Privacy Policy is necessary, it is not going to change.
- The title, description and thank-you message are fine, but it's going to be hard to retrieve from the HTML with that layout. It's easier if that information is in the node itself. For example:
- Using classes:
<p class="title">Join the Frontity newsletter</p> <p class="description">Stay up-to-date on new releases and features, tutorials, and community news.</p> <p class="thank-you">Thank you! You have been subscribed to the Frontity newsletter. You will receive a welcome email shortly.</p>
- Using children order (1st title, 2nd desc, 3rd thank-you):
<p>Join the Frontity newsletter</p> <p>Stay up-to-date on new releases and features, tutorials, and community news.</p> <p>Thank you! You have been subscribed to the Frontity newsletter. You will receive a welcome email shortly.</p>
- Using classes:
from frontity.org.
In order to test if the logic of the old implementation could work, and check the best way to connect Gutenberg and React, I created this draft Pull Request #75 . It works so I guess the migration is possible. I share it in case it's useful as an starting point.
from frontity.org.
Related Issues (20)
- frontity.org not working in Safari 11.1 HOT 8
- Frontity website has layout issues and missing content on MS Edge on Windows HOT 4
- The `font-weight` is not applied correctly to headings on safari=<11
- Images of our blog are redirecting to the wrong URL HOT 1
- Fix layout in 404 page HOT 3
- The Frontity logo svg placed in the demo iframe isn't loading correctly sometimes
- body background keeps showing on scroll HOT 4
- Frontity default state.source donβt fetch all items once in loop HOT 1
- Mobile menu does not close on click HOT 6
- CF7 forms does not work HOT 1
- Merge dev to master HOT 2
- Wrong styles on "visited" links? HOT 1
- Update deploy/lighthouse workflow HOT 1
- Author links don't work [1pt] HOT 1
- Blog Search is not working HOT 1
- Add redirects to links with campaigns
- Hero section does not render as expected HOT 1
- Replace embedded asset of the Twenty Twenty theme (performance section) with an image HOT 2
- Change the font-display to swap instead of block
- "Community" link is broken HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from frontity.org.