Comments (11)
Love this @sunithapatel , thanks for creating this issue.
from frontendstudygroup.github.io.
This is so nice. I would like to work on this. @sunithapatel assign me to this.
from frontendstudygroup.github.io.
Sure, you got it!
from frontendstudygroup.github.io.
By the way, feel free to design the table and those buttons anyway you like - this was only a suggestion of some patterns I have seen with this before. :)
from frontendstudygroup.github.io.
@princiya and @sunithapatel
Created the Toggle button for the card/table view and its functionality is working well. I have an issue with the Table view. The table header gets the data from ResourceList using Object/key mapping. So It retrieves all the keys and renders the empty <th>
tag. But it is required to have an ID, name, and URL for my table view.
from frontendstudygroup.github.io.
Can I make PR to review my code?
from frontendstudygroup.github.io.
Yes, you can make a PR and we can review it.
from frontendstudygroup.github.io.
It sounds like the table header should not be part of getting the data, you should just set it to the 3 columns. The <tr>
is what needs to be mapped from the data.
But can take a look at your code to be sure. :)
from frontendstudygroup.github.io.
I made PR - it shows 'All checks have failed'. Anything that I missed?, I am not sure about this error.
from frontendstudygroup.github.io.
I made PR - it shows 'All checks have failed'. Anything that I missed?, I am not sure about this error.
Commented on this in the PR. Let us know if you need more help understanding how to fix it.
from frontendstudygroup.github.io.
Fixed #44
from frontendstudygroup.github.io.
Related Issues (20)
- Design Contact Us form HOT 14
- Create page to show list of open source internships as Cards view HOT 7
- Deploy React App to AWS with AWS Amplify HOT 8
- Set up continuous integration with GitHub Actions HOT 1
- Detail view for the json data HOT 9
- Design and implement a footer component HOT 10
- PWA support - Make it installable on any device and show offline page when user's internet is not connected HOT 4
- Contact Form Validation HOT 1
- Refactor the input field component HOT 2
- Design About Page HOT 6
- Improve information displayed for resources HOT 1
- Create unit tests for Resources component HOT 9
- Filter resources by location HOT 2
- Visualizing a Github repo HOT 1
- Making a certificate template for the website for the contributors HOT 4
- URL access to bubblechart HOT 1
- Improving existing UI of Homepage HOT 11
- Homepage UI HOT 2
- Homepage functionality HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from frontendstudygroup.github.io.