Coder Social home page Coder Social logo

Comments (11)

princiya avatar princiya commented on August 17, 2024 1

Love this @sunithapatel , thanks for creating this issue.

from frontendstudygroup.github.io.

Priyami avatar Priyami commented on August 17, 2024

This is so nice. I would like to work on this. @sunithapatel assign me to this.

from frontendstudygroup.github.io.

sunithapatel avatar sunithapatel commented on August 17, 2024

Sure, you got it!

from frontendstudygroup.github.io.

sunithapatel avatar sunithapatel commented on August 17, 2024

By the way, feel free to design the table and those buttons anyway you like - this was only a suggestion of some patterns I have seen with this before. :)

from frontendstudygroup.github.io.

Priyami avatar Priyami commented on August 17, 2024

@princiya and @sunithapatel
Created the Toggle button for the card/table view and its functionality is working well. I have an issue with the Table view. The table header gets the data from ResourceList using Object/key mapping. So It retrieves all the keys and renders the empty <th> tag. But it is required to have an ID, name, and URL for my table view.
Tableview

from frontendstudygroup.github.io.

Priyami avatar Priyami commented on August 17, 2024

Can I make PR to review my code?

from frontendstudygroup.github.io.

sunithapatel avatar sunithapatel commented on August 17, 2024

Yes, you can make a PR and we can review it.

from frontendstudygroup.github.io.

sunithapatel avatar sunithapatel commented on August 17, 2024

It sounds like the table header should not be part of getting the data, you should just set it to the 3 columns. The <tr> is what needs to be mapped from the data.
But can take a look at your code to be sure. :)

from frontendstudygroup.github.io.

Priyami avatar Priyami commented on August 17, 2024

I made PR - it shows 'All checks have failed'. Anything that I missed?, I am not sure about this error.

from frontendstudygroup.github.io.

sunithapatel avatar sunithapatel commented on August 17, 2024

I made PR - it shows 'All checks have failed'. Anything that I missed?, I am not sure about this error.

Commented on this in the PR. Let us know if you need more help understanding how to fix it.

from frontendstudygroup.github.io.

princiya avatar princiya commented on August 17, 2024

Fixed #44

from frontendstudygroup.github.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.