Comments (3)
For anyone interested, here his my self defensive code:
safe.js
import NextRouter from 'next/router'
export default function safe(subdomain) {
if (process.browser && NextRouter.subdomain && NextRouter.subdomain !== subdomain) {
throw new Error(`Leak between ${subdomain} and ${NextRouter.subdomain}`)
}
NextRouter.subdomain = subdomain
}
www/routes.js
import nextRoutes from 'next-routes'
import safe from './safe'
safe('www')
const routes = nextRoutes()
routes.add('www/home', '/')
// ...
export const Router = routes.Router
export const Link = routes.Link
export default routes
admin/routes.js
import nextRoutes from 'next-routes'
import safe from './safe'
safe('admin')
const routes = nextRoutes()
routes.add('admin/home', '/')
// ...
export const Router = routes.Router
export const Link = routes.Link
export default routes
from next-routes.
Thanks, I agree it would be better to not modify it. It was it's own object before, but there was a problem with Router events: #18 If you could send a PR that solves this would be really cool.
from next-routes.
I'm fine with the checks I have added in userland, I need them independently of this issue. It's not a priority for me. Feel free to close the issue.
from next-routes.
Related Issues (20)
- Click on link and URL update is not working HOT 1
- Complex { Link } from routes module doesn't work when coming from static pages, but does when navigated to first HOT 5
- next 9 with next-routes and public folder not working
- Route pushRouter makes app refresh
- Empty value for route
- Nextjs v9 - Parameter 'url' must be a string, not undefined HOT 1
- Is this library alive? HOT 22
- Refresh results in 404 page not found HOT 4
- Bug with getServerSideProps HOT 2
- Compatibility with getStaticPaths HOT 1
- Error using Link component "Warning: Function components cannot be given refs." HOT 1
- Failed to decode downloaded font
- slugs are not working with dynamic routes after upgrading to next 9.5 HOT 2
- assigning the index page to multiple routes leads to infinite reloading HOT 1
- Page Both Accessible From Route Url And NextPage Name HOT 1
- Next 10 HOT 2
- React 17.02, next js 11 HOT 2
- Migrating from next-routes to built-in Next.js routing? HOT 1
- vercel deployment with this lib
- Migration steps for nextjs inbuilt routing HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from next-routes.