Softdelete and race condition on logout about connect-typeorm

[0x0ece]

FYI, in the meantime we've released our modified version of express-session:
https://github.com/saasform/saasform/tree/main/packages/express-session

The new MemoryStore prevents resaving destroyed sessions, i.e. does what I'm planning to implement here.

We also added tests to validate that the original express session suffers from the race condition, while in the new implementation the race condition is fixed.

[nykula]

Hi! Asking the users to add a column to their entity is a major API change, but it's time to bump the major anyway. Old typeorm has known dependency vulnerabilities, so before any new release I should bump the version requirements and remove the code paths no longer used. I don't know when I'll have time to work on this, so I welcome your pull requests. #7 (test cases for custom type-safe session fields) and #24 (debug tediousjs Bigint issue) have been on my todo list for quite a while, too.

[0x0ece]

ok thanks - I'll work on it. Definitely agree it's a major API change.

[0x0ece]

I opened a PR - it turned out to be much more simple and at the same time much more complex than expected. Simple because typeorm has the soft delete. Complex because just the soft delete didn't solve the update issue.

Please take a look at the comments in the PR and lmk your thoughts. If this is too big of a change we can also publish this as @saasform/typeorm-connect like we did for express-session.

[nykula]

LGTM so merged, thank you! To anyone also reading this, please see if you can suggest how to work around the need for (session as any) cast with recent express-session typings.

[0x0ece]

Great, thank you! Please lmk when you file a new release so I'll note the version.

[jdhuntington]

Thanks for this PR!

I noticed that with this change, any soft deletes are likely to persist forever. There might be a subtle timing issue if a logout happened close in time to when a session would expire, but I believe #27 is a useful fix for most use cases.

[freshgiammi]

Merged.