Comments (4)
who defined the tradingview implementation as the "correct" one?
This indicator has an original author (as do most others) - implementations should try to follow this formula, not the implementation of a random, closed source tool.
If tradingview deviates from the original author, you should ask them for "their" formula, so an "atr_tradingview" might be added.
That said - ATR is "vendored" from qtpylib (you'll see this from the location of the function / file containing this function).
This means, it's basically a 1:1 copy of the file from qtpylib (with some style changes to make flake pass).
If you think it's wrong (based on the original author spec though), an issue should be opened there.
I don't think we should make deviations in our copy of the file (other than stylistic changes) to keep the update-process simple (should their file be updated) - unless we determine for sure that qtpylib (and the indicators provided by it) are no longer supported (confirmation by the original author, basically), in which case we can add a comment specifying that it's now "our" version, no longer kept uptodate with eventual changes in qtpylib.
Feel free to investigate further and propose a PR improving the calculation - personally, i'll not have time to work on this in the forseeable future - mainly because these investigations very often take hours or days - and determining "the correct way" is not straightforward anyway.
from technical.
I mentioned clearly 'built-in' indicator. NOT written by 3rd party.
As TradingView nowadays used almost by everyone I believe many people relay on it.
And it was discussed already in #26
So it's good for all of us to find out what's issue now.
from technical.
You said Tradingview Builtin.
This does NOT mean that the indicator is correct based on the original author - but tradingview could've modified the formula (slightly or fully).
So it's good for all of us to find out what's issue now.
Yes, please let us know what the correct calculation should be once you found out.
from technical.
I guess 3 different atr calculation codes have been added. Maybe it works for you
from technical.
Related Issues (20)
- Resampled dataframes are shifted 1 candle. HOT 4
- Trend Step Channel - appreciate it HOT 4
- resample_to_interval date shifted HOT 1
- Help with Trend Trader Strategy HOT 1
- ichimoku different value proposal HOT 1
- How to import external data to populate entry/exit trend conditions HOT 14
- Multiple timeframe merge HOT 10
- Laguerre RSI wrong computation HOT 3
- ```crossed``` function throws error with numpy integers
- utils bug HOT 4
- How to plot segtrends or gentrends using freqtrade plot-dataframe ? HOT 1
- Phase Change Index HOT 18
- I try to convert Predictive Ranges [LuxAlgo] to the py, whats the problem? HOT 7
- Involvement of Heikenashi candles could be helpful in trend prediction HOT 1
- Help needed with: AttributeError: 'SSL' object has no attribute 'copy' HOT 3
- warning util.py
- 16 tests failed HOT 4
- Pandas warning when setting fillna(0) on RMI calc HOT 2
- Issues with PMAX indicator HOT 1
- A few Pinescript lines HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from technical.