ended event not firing on mobile. about iphone-inline-video

[jimmymain]

I added the following code:

    window.setInterval(function() {
        jQuery('div.notify').html(`end: ${video.ended}, ${video.currentTime}, ${video.duration}`);
    }, 1000);

the current time and duration are logged correctly, but the numbers are not identical on the ipad and iphone. Looks like a rounding error.

desktop: end: true, 9.357641, 9.357641
iphone: end: false, 9.3566666, 9.35666666666666667.

If you are measuring the time, I think you might need to use an epsilon comparison?
I will try and re-encode the video, and clip a second off, might also help.

[fregante]

If you want to enable it on the iPad: #22 (comment)

---

Normally the ended event should fire (https://github.com/bfred-it/iphone-inline-video/blob/gh-pages/index.js#L87). When the video ends, could you verify that the ended property is true on the video with Safari's remote debugger? (e.g. video.ended) If not, verify that the .currentTime matches .duration. It sounds strange that the iPad isn't triggering the event, considering that the module doesn't affect it at all.

[jimmymain]

I am on windows, so that is tricky.
Will it help if you can browse to our test site

You can see a div with the status text on it, which changes under chrome and firefox, but not iphone or ipad.

The video there is now working rather nicely on iphone and ipad so thanks very much for that.
All that remains is that I want to restart the video when it finishes, but alas that event is not triggering on the pad or phone. For reference the jquery is in video.js

Thanks!

[jimmymain]

I have reencoded the video and the end event is now triggering. Judging by what I have been reading video on mobile is a minefield.

Not sure if you want to chalk this up to a glitch. Perhaps you have some idea why the duration was a rounding error higher than the current time.

[fregante]

Would you mind sending me the video? There could be issues in setting the time to that specific value (i.e. the browser resets 9.35666666666666667 to 9.3566666 when setting currentTime and the only solution is to calculate .ended manually, but it might not show the very last frame in some cases)

[fregante]

I published v1.5.0, can you verify that it works with your old video? I skipped the manual currentTime clamping — the browser does it automatically, which means that if you set currentTime = 10 it should reach the end of the video at 9.35666666666666667

[fregante]

I'd love to get this fixed—before I or anyone else bumps into this

[fregante]

Eventually I did bump into this with a video having a length of 2.5025025025025025