Videomails can't be played on iPhones about iphone-inline-video

[fregante]

iphone-inline-video is javascript
Most email clients don't support javascript

[binarykitchen]

No, not email. Just click on the link in the email to open the web page. Video won't play on Safari.

[fregante]

My bad, I'm seeing that now. Make sure that you call makeVideoPlayableInline() after setting the src to the video

[fregante]

Actually, I'm not seeing the props on the <video> element at all, so make sure that the function is actually called

These should appear at the bottom of the output of dir(video) in the console via remote debugger:

[binarykitchen]

ok, will try tomorrow, thanks

[binarykitchen]

@bfred-it Hmmm, I moved makeVideoPlayableInline after setting the src's to the video. Still no luck.

See changes at
https://github.com/binarykitchen/videomail-client/blob/master/src/wrappers/visuals/replay.js#L92

that show() function is called after mp4 + webm sources are set.

Have bumped www.videomail.io with these changes - if you do not mind to check again, that would be very much appreciated.

[fregante]

The video width is 0

Once I set that to something else the video appears, but for some reason the module is not running because the symbols are not there and the video plays fullscreen. Also you're missing the CSS to hide the play button https://github.com/bfred-it/iphone-inline-video#usage

Again, the issue is somewhere in your code and I can't debug that

[binarykitchen]

Right, I can reproduce all the above with Valence now (but have added the missing CSS).

So, I have really no idea why width is set to 0. In the Videomail-Client code I set the width and height of the video dom element before the makeVideoPlayableInline() call. Is that good or should I set width/height after that call?

See from https://github.com/binarykitchen/videomail-client/blob/master/src/wrappers/visuals/replay.js#L86

[fregante]

Video size shouldn't affect the module. You just need to make sure that the src or currentSrc properties are set when you call that function.

[binarykitchen]

@bfred-it ah, finally got it. the height was wrongly calculated before. works well on iphones now :)

but why does the video play full-screen and not inline? any ideas why?

[fregante]

Re-read this: #16 (comment)

You're not calling the function. On your website I called it on the video and it works.

The only limitation is that you can't use the browser's play/pause buttons: #16 (comment)