libfreerdp-gdi ScrBlt about freerdp

[otavio]

In my opinion this is not a blocking issue for 1.0.

I think we ought to leave it to 1.1.

[awakecoding]

@otavio: it is a non-issue if this turns out to be a specific to Windows 8, but I suspect Windows 8 might have simply triggered a pre-existing condition that could affect earlier versions of Windows as well. I think that the quick succession of CPU-intensive calls like ScrBlt might have uncovered a synchronization issue related to the access of the software buffer used by libfreerdp-gdi. Once in a while I see artifacts when using libfreerdp-gdi, so this might finally be the source of these sporadic issues.

[otavio]

Ahh; I see.

In this case I agree :-D

[awakecoding]

I have just tried reproducing the issue without success. I know that Windows 8 Developer Preview gets updates through Windows Update, so this might have been a server bug but I'm pretty sure the problem was only noticeable with --gdi sw and not --gdi hw. Still, I got rid of the gdi_copy_mem and gdi_copy_mem_backwards functions in libfreerdp-gdi in favor of calls to memmove. If anybody else notices this issue again, feel free to re-open this issue. I'm closing it now since I cannot reproduce it any more.