Coder Social home page Coder Social logo

Comments (2)

celsius avatar celsius commented on May 29, 2024

here is a patch that fixes the issue (loss of pointer "targetNetAddresses" because of redirection->targetNetAddresses++; ) :

diff --git a/libfreerdp-core/redirection.c b/libfreerdp-core/redirection.c
index 5e6c0e5..0f1e07d 100644
--- a/libfreerdp-core/redirection.c
+++ b/libfreerdp-core/redirection.c
@@ -138,12 +138,13 @@ boolean rdp_recv_server_redirection_pdu(rdpRdp* rdp, STREAM* s)

                redirection->targetNetAddresses = (rdpString*) xzalloc(count * sizeof(rdpString));

-               while (count > 0)
+
+               int i;
+
+               for (i=0; i < count; i++)
                {
-                       freerdp_string_read_length32(s, redirection->targetNetAddresses, rdp->settings->uniconv);
-                       DEBUG_REDIR("targetNetAddresses: %s", redirection->targetNetAddresses->ascii);
-                       redirection->targetNetAddresses++;
-                       count--;
+                       freerdp_string_read_length32(s, &redirection->targetNetAddresses[i], rdp->settings->uniconv);
+                       DEBUG_REDIR("targetNetAddresses: %s", (&redirection->targetNetAddresses[i])->ascii);
                }
        }

from freerdp.

celsius avatar celsius commented on May 29, 2024

NB: the patch fixes one segfault but there are others happening after this one is corrected (notably in the freeing of the cache, rdp and xfi). These also happen only when logging out after a redirection, I'll try to look into it.

from freerdp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.