Comments (2)
here is a patch that fixes the issue (loss of pointer "targetNetAddresses" because of redirection->targetNetAddresses++; ) :
diff --git a/libfreerdp-core/redirection.c b/libfreerdp-core/redirection.c
index 5e6c0e5..0f1e07d 100644
--- a/libfreerdp-core/redirection.c
+++ b/libfreerdp-core/redirection.c
@@ -138,12 +138,13 @@ boolean rdp_recv_server_redirection_pdu(rdpRdp* rdp, STREAM* s)
redirection->targetNetAddresses = (rdpString*) xzalloc(count * sizeof(rdpString));
- while (count > 0)
+
+ int i;
+
+ for (i=0; i < count; i++)
{
- freerdp_string_read_length32(s, redirection->targetNetAddresses, rdp->settings->uniconv);
- DEBUG_REDIR("targetNetAddresses: %s", redirection->targetNetAddresses->ascii);
- redirection->targetNetAddresses++;
- count--;
+ freerdp_string_read_length32(s, &redirection->targetNetAddresses[i], rdp->settings->uniconv);
+ DEBUG_REDIR("targetNetAddresses: %s", (&redirection->targetNetAddresses[i])->ascii);
}
}
from freerdp.
NB: the patch fixes one segfault but there are others happening after this one is corrected (notably in the freeing of the cache, rdp and xfi). These also happen only when logging out after a redirection, I'll try to look into it.
from freerdp.
Related Issues (20)
- when i use app-cmd open an file such "1 2.txt" with space,it divided into two parts "1" and "2.txt" how can i open "1 2.txt" as a whole HOT 2
- [BUG] Black of screen when connecting with remmina and enabled `dynamic resolution update` feature. HOT 2
- Doesn't Compile HOT 1
- zsh: command not found: xfreerdp HOT 2
- current master WITH_LIBRARY_VERSIONING=OFF buggy
- app_id should be set to wm-class
- clipboard data Failed to connect to a new session HOT 7
- [server terminates connection] Upgrading from 2.x to 3.x SSL read errors after connect HOT 25
- Upgrading from 2.x to 3.x introduces TLS security schema issues HOT 3
- xfreerdp 2.11.5 still broken with: "Fastpath update Bitmap [1] failed, status 0" HOT 9
- Can not use bottom of the screen with the mouse if monitor resolution differs HOT 1
- client/X11: Trying to paste copied files from a server crashes xfreerdp HOT 8
- -
- Compiler warning: xxxx called on pointer returned from a mismatched allocation function HOT 6
- More compiler warnings HOT 2
- stable-2.0 branch fails to build with GCC 14 HOT 1
- [sdl] Should /kbd:remap:KEY=VALUE work? HOT 1
- Multiple monitors acts weirdly under Plasma 6 Wayland HOT 3
- Crash is occurring in FreeRDP at the time of ERRINFO_LOGOFF_BY_USER in desktop screen in Android with Freerdp 2.11.2
- Crash is occurring in FreeRDP at the time of ERRINFO_LOGOFF_BY_USER in desktop screen in Android with Freerdp 2.11.2 HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from freerdp.