Partial bug fix for AddRemovePathEdges about freerct

[GoogleCodeExporter]

Empty diffs, whoops

Original comment by [email protected] on 25 May 2014 at 9:30

Attachments:

• path.patch
• path_build.patch

[GoogleCodeExporter]

Change according to style guidelines :)

Original comment by [email protected] on 25 May 2014 at 10:15

Attachments:

• path.patch

[GoogleCodeExporter]

Forgot a part

Original comment by [email protected] on 25 May 2014 at 10:20

Attachments:

• path.patch

[GoogleCodeExporter]

Happy now?
GEEZ

Original comment by [email protected] on 25 May 2014 at 10:39

Attachments:

• path.patch

[GoogleCodeExporter]

i found a couple of bugs with your patch:

- (minor) removed the check for the world border (readding it works fine)
- path_build changes don't seem to work (building downward still fails)
- building from flat -> sloped does not connect the pieces (see middle and 
right slopes in http://i.imgur.com/N8AYehU.png)

- (minor) left an iostream include in the patch file

Original comment by [email protected] on 26 May 2014 at 11:25

[GoogleCodeExporter]

The path_build changes were only to get the correct zpos parameter, so were not 
intended to fix the actual path building.

Fix is still only partial, so I'm still checking some of the issues you 
described, like what goes wrong when building a path from upward -> flat 

Original comment by [email protected] on 27 May 2014 at 7:53

[GoogleCodeExporter]

Please try to make as few changes in a patch as possible. Things like variable 
renaming and comment shuffling cause a lot of noise. It's impossible to see 
what change you are actually making this way. Without that understanding I 
cannot give you any help if you need it, nor will the patch get accepted.

Really only make changes that must be done, and leave everything else alone, 
even if you feel it can be improved. If you must change other things, then at 
least split the functional changes from the non-functional ones.

A good rule of the thumb is "one conceptual change in the code" == "1 patch" == 
"1 commit".

Original comment by [email protected] on 29 May 2014 at 10:29

[GoogleCodeExporter]

Fixed in recent commits

Original comment by [email protected] on 7 Aug 2014 at 4:30

• Changed state: Fixed