Coder Social home page Coder Social logo

Comments (6)

xiahengchen avatar xiahengchen commented on June 12, 2024 2

Hello @iksent, We're happy to inform you that we have found the reason why you are facing above issue. The issue was related to yarn install. Our team is almost using npm install, not yarn install and npm install is installing all above packages as default what you mentioned. In terms of this issue, we added them to package.json and so you can check the changes on this branch. Thanks for your feedback. :)

from pricing-page.

vovafeldman avatar vovafeldman commented on June 12, 2024 1

Hey @iksent, I did a quick look and found out that FontAwesome is entirely compiled with the app, so that's something that can be definitely replaced/optimized. Please note that it will take us some time to get to it.

from pricing-page.

vovafeldman avatar vovafeldman commented on June 12, 2024 1

Hey @iksent, kindly try this branch optimized for production by our senior ReactJS developer, @xiahengchen, and let me know how it goes (the compiled version should be less than 400Kb now).

from pricing-page.

iksent avatar iksent commented on June 12, 2024

Hello @vovafeldman, @xiahengchen!

Tried to build "feature/optimize-performance" branch, but got the errors like:

ERROR in ./src/components/FreemiusPricingMain.js
Module not found: Error: Can't resolve 'css-loader' in 'C:\Programming\freemius-pricing-page'
 @ ./src/components/FreemiusPricingMain.js 4:0-35
 @ ./src/index.js

Due to "style-loader", "css-loader", "sass-loader" and "file-loader" are not exist in package.json

When I added them to the project by myself, then I got 340kb for freemius-pricing.js - this is a good result, I think.

from pricing-page.

xiahengchen avatar xiahengchen commented on June 12, 2024

Hello @iksent
We appreciate your feedback. But as you know, when you create your React app, you can see dependencies something like "style-loader", "css-loader" and "file-loader" as default in your node_modules folder. That's why we didn't include these packages in our package.json. Please let me know if you still have any problems on your end. Thanks.

from pricing-page.

iksent avatar iksent commented on June 12, 2024

My opinion is that when you clone some repository everything should work after git clone and yarn install.
I see no reason not to add dependencies to your package.json

from pricing-page.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.