Comments (4)
@kevcomedia Thanks for pointing out this issue. I did some investigating, because this was news to me, and it turns out it is not the test suite itself, but Mocha's CSS which is overriding this rule in your example:
#mocha h1, #mocha h2, body {
margin: 0
}
This may be because we have mocha css hard coded into the project in order to keep everything bundled nicely for campers, I suspect that if mocha was pulled in as a CDN, the order of the stylesheets would change, and this would not be the case.
That said, I did check for other such conflicts and there are none, so a quick solution to this would just be to add !important
to your rule.
Hope this helps! Thanks again and happy coding!
from testable-projects-fcc.
If the css is hard-coded, maybe it can be removed? It's the only (simple) selector in the mocha css that doesn't target any class or id, and it doesn't seem to serve any real purpose. And it might trip other campers later on, especially when beta goes live.
from testable-projects-fcc.
@kevcomedia You know, I thought of this yesterday just after leaving the comment as I looked closer at the code. I would agree — so far as I can tell, in this instance it seems to serve zero purpose, and it definitely may help more inexperienced campers especially.
Feel like making a quick PR? Again, thanks for bringing this to my attention.
p.s. and sorry for the late reply, I've been very caught up in another project lately, and unfortunately I'm the only one monitoring this repo at all right now.
from testable-projects-fcc.
There you go 🙂
If something's not right let me know. And I don't mind the late reply at all 😃
from testable-projects-fcc.
Related Issues (20)
- test issue when i'm working with survey project , test shows test failed list of tribute page HOT 1
- Test failing but test requirement has been met HOT 1
- getting an error on product landing page #landing test. it says the navbar should always be at the top of the page. the navbar is at the top of my page but i am still receiving the error. HOT 1
- FCC Personal Portfolio - Can't get Layout #3 test to pass regarding navbar and viewport HOT 2
- project verification script not detecting required id tags in my code HOT 1
- User Story #11: Within the form, there is a submit input with a corresponding id="submit" HOT 1
- Test scripts are not correct HOT 1
- Personal Portfolio Project Bugs
- i think this is bog, 3 hour i am trying HOT 1
- Pomodoro Clock #15 Test of "25 + 5" Test Suite May Be Yielding Incorrect Results HOT 3
- Survey Form Test Issues
- FCC: Tribute Page
- Potrfolio tests: typo in #Content test number 4
- the test is not running HOT 1
- Markdown Preview tests not compatible with Vue HOT 1
- TypeError: Cannot read property '1' of null for Pomodoro clock. Why?????!!!!!!! HOT 1
- Issue with image running Tribute Page tests HOT 2
- Dependency Dashboard
- Build a JavaScript Calculator tests typo HOT 3
- incomplete fix for 25+5 with React@18 in #1485
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from testable-projects-fcc.