"The <header> element with id='header' should always be at the top of the viewport" step failing when using Bootstrap class navbar-fixed-top about testable-projects-fcc

[Christian-Paul]

@kev0587 Thanks for the detailed bug report!

While technically the old test was working properly (the header element in your project wasn't at the top of the viewport, though the nav element was), the test should definitely be changed to accommodate for how bootstrap and other libraries achieve this.

I don't want to check for library specific classes, since we'd have to take every popular library/version into consideration, and I'd rather verify that some element that's serving as a navbar is actually at the top rather than assuming the user implemented the library's class properly.

That being said, I think the best way to go about testing this is to obtain the positions of the header element and its children, and to use the element whose position is closest to the top for our test.

[no-stack-dub-sack]

@Christian-Paul are you going to take this one on?

[Christian-Paul]

@no-stack-dub-sack Yup, working on it now