Coder Social home page Coder Social logo

Comments (4)

Lakston avatar Lakston commented on August 12, 2024

I did not encounter this problem, finished project can be seen here : https://lakston.github.io/d3-heatmap/

from testable-projects-fcc.

tchaffee avatar tchaffee commented on August 12, 2024

@paycoguy @Christian-Paul @QuincyLarson @tbushman @no-stack-dub-sack I suggest the same solution for this as for issue #70. I would just change the test text to better reflect what it is actually testing:

"The heat map cells must have a data-month attribute, and cells with a month earlier in the year must appear above cells with a later month in the year"

If possible I would like some feedback before moving ahead.

from testable-projects-fcc.

andrealonzo avatar andrealonzo commented on August 12, 2024

Yes, we should impose a sort order on the axis. As you can see, some campers find the tests too restrictive, but I think it's too hard to create flexible tests to account for every possible variation.

from testable-projects-fcc.

tchaffee avatar tchaffee commented on August 12, 2024

@paycoguy Thanks for your quick response and your input. It looks like @tbushman actually dug into this and came up with a solution to check that the axis aligns with the data points, and it should work no matter how the camper sorts the data. PR #127.

from testable-projects-fcc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.