Original intent of Doping in bike Racing is lost with these axes. about testable-projects-fcc

[QuincyLarson]

@tchaffee I think @paycoguy's implementation looks great, and I see his point about revealing additional data by changing the X axis. I think we can leave this as is.

[no-stack-dub-sack]

@AdventureBear I'm cc'ing @Christian-Paul and @paycoguy who created this project and tests to get their opinion on this one. I'm a little out of the loop when it comes to the D3 projects. Thanks.

[AdventureBear]

Great, 8; there is a compelling reason to change the challenge that's fine, but aside from what I already wrote, sorting and using that as an axis is another small js challenge

[AdventureBear]

Better yet, can we add a transition?

[andrealonzo]

@AdventureBear

I understand what you're saying and thank you for being the one that created this graph.

The reason I changed the way the data was visualized was mainly from a scatterplot perspective. When I think of a scatterplot, I think of something like this:

http://bolt.mph.ufl.edu/files/2012/07/images-mod2-scatterplot4.gif

Here, we have variables and we want to see if there is a correlation between the variables.

In the original doping scatter plot, the finishing place is directly related to finishing time, so there is no need for this to be presented as a scatter plot. It could be presented using only 1 axis, or a line graph.

In the new doping scatter plot, the dots are actually "scattered". I think the new plot still shows the sheer amount of doping allegations, but also shows doping allegations over time.

@no-stack-dub-sack and @QuincyLarson
Since this is not a technical issue, I will defer to you on what we should do. We can go back to the original plot, stay with the new plot, or choose a data set. I'm fine either way.

For your reference, here is the original plot

https://codepen.io/freeCodeCamp/full/ONxvaa

Here is the new plot

http://codepen.io/paycoguy/pen/QGYVeb

[no-stack-dub-sack]

@paycoguy @AdventureBear I understand what you're saying here @paycoguy ☝️ and agree that this is a better example of an actual "scatter" plot in the end. The original visualization does not necessarily require a scatter plot to achieve the same effect. Visually, I think the original it is more impressive - although that's not necessarily what we're after.

@AdventureBear The idea of a transition is pretty badass, and would certainly show multiple perspectives on the same data, however, our goal in revamping the projects here, is to keep them as relatively simple as possible, because feedback from campers on previous projects was that cool effects and transitions intimidated them too much. So while I think that's a great idea, I think it might be overkill for what we're trying to achieve. Do you see the value in @paycoguy's reasoning?

[AdventureBear]

Sure I understand the reasoning between the way I did the original graph and the discussion about a true scatterplot. My gut tells me though that this data is not a good set for a scatter plot with the given information. The year is kind of an arbitrary value creating more noise than anything else for the dataset as a whole. The nature of bike racing influences the times up the alp d'heuz so that for each given year, the racers are not racing the clock, but racing strategically against each other, and for each year the weather & wind conditions affect time as well. If we want to do a true scatterplot something relating to this dataset, adding in riders weight would be a great datapoint, so that the relationship between hill climbing ability and weight can be seen graphically. that'd be cool. I can gather that dataset and then there'd be lots of interesting options for the campers that want to play with the set.

…

On Wed, Feb 22, 2017 at 8:20 PM, Peter Weinberg ***@***.***> wrote: @paycoguy <https://github.com/paycoguy> @AdventureBear <https://github.com/AdventureBear> I understand what you're saying here @paycoguy <https://github.com/paycoguy> ☝️ and agree that this is a better example of an actual "scatter" plot in the end. The original visualization does not necessarily speak to the value of a scatter plot itself. @AdventureBear <https://github.com/AdventureBear> The idea of a transition is pretty badass, and would certainly show multiple perspectives on the same data, however, our goal in revamping the projects here, is to keep them as relatively simple as possible, because feedback from campers on previous projects was that cool effects and transitions intimidated them too much. So while I think that's a great idea, I think it might be overkill for what we're trying to achieve. Do you see the value in @paycoguy <https://github.com/paycoguy>'s reasoning? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#55 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AG2eTkfL-CMyx6R-vaMqS7XckZNDkflYks5rfN75gaJpZM4MGlFy> .

-- ----- Suzanne Atkinson, MD Clinical Instructor of Emergency Medicine University of Pittsburgh School of Medicine Emergency Resource Management, Inc. Head Coach & Founder Steel City Endurance Coaching *Schedule a Swim lesson, Podcast or Coaching consult here:* http://www.booknow.so/SteelCity *Get 3 Free Swim Practices ...* *https://steelcity.leadpages.co/fresh-freestyle-sample-practices/ <https://steelcity.leadpages.co/fresh-freestyle-sample-practices/>*

[no-stack-dub-sack]

@AdventureBear A little late in getting to this, but if you want to fork the repo and add the data set and make sure everything still works with the tests, I see no harm in that, and would only strengthen our example. Up to you and whether or not you'd like to take the initiative to do that here

If you decide to, and have any questions about the repo, feel free to ping me on Gitter

[AdventureBear]

the night I wrote this I started to collect all the data but ran out of steam. What's the timeline on this right now ?

…

On Tue, Mar 21, 2017 at 7:20 PM, Peter Weinberg ***@***.***> wrote: @AdventureBear <https://github.com/AdventureBear> A little late in getting to this, but if you want to fork the repo and add the data set and make sure everything still works with the tests, I see no harm in that, and would only strengthen our example. Up to you and whether or not you'd like to take the initiative to do that here — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#55 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AG2eTrf4U06xqstEtpm1muRlP6dGnS4oks5roFtNgaJpZM4MGlFy> .

-- ----- Suzanne Atkinson, MD Clinical Instructor of Emergency Medicine University of Pittsburgh School of Medicine Emergency Resource Management, Inc. Head Coach & Founder Steel City Endurance Coaching *Schedule a Swim lesson, Podcast or Coaching consult here:* http://www.booknow.so/SteelCity *Get 3 Free Swim Practices ...* *https://steelcity.leadpages.co/fresh-freestyle-sample-practices/ <https://steelcity.leadpages.co/fresh-freestyle-sample-practices/>*

[no-stack-dub-sack]

@AdventureBear None. lol. Ongoing dev. Take your time - none of this will be official until beta is rolled to production, if you get to it, we can review at that point, if you don't no biggie!

[Lakston]

I just finished this one and agree with @AdventureBear (I just created a topic on FCC forums about it).

Here is my version of it with the test suite included (I obviously can't pass the test because I do not respect the axes suggested by the challenge).

I chose ranking / time behind fastest athlete because that's the data I had in hand, it presents the data in a more readable way and still uses the same json input.

Edit : Ok i just re-read some posts here and realise I actually used the 'old way' of presenting the data, I hadn't clicked on the links, silly me, I much prefer this presentation (maybe I saw it a long time ago and had it in the back of my mind).

[no-stack-dub-sack]

@Lakston but what about the argument the data is not "scattered" in the original presentation? I tend to agree that while the data is more readable in the older presentation, the current version is a more accurate picture of a scatter plot, and a scatter plots point, is not necessarily to have the most easily readable data, but to show a scattered relationship

[tchaffee]

@no-stack-dub-sack @QuincyLarson Can someone make a decision about what we want to do with this or can we close it? I do like the old presentation of the data a little better, but in terms of getting experience creating a scatter plot there isn't much difference between the two approaches. So unless someone is willing to re-write the tests to fit the the other layout, then I'm ok with keeping this as-is.