Coder Social home page Coder Social logo

Comments (3)

no-stack-dub-sack avatar no-stack-dub-sack commented on August 12, 2024

@DarrenfJ you can go ahead and re-fix your pen if you'd like - I've forked your project here to preserve the issue. Thanks for reporting this! I'll look into this and should be able to fix.

Just to clarify though, on my end it seems to be failing #Content tests 4 & 5 and #Layout test 2 - not the last 3 tests, is that what you're seeing on your end? It's consistent with what you're describing as to why the tests fail

from testable-projects-fcc.

no-stack-dub-sack avatar no-stack-dub-sack commented on August 12, 2024

@DarrenfJ Thanks again for pointing this out - I've fixed the tests so now the broken one that I forked to preserve has all tests passing (with your original code). The issue was that the test was previously assuming id="image" & id="img-caption" would be a direct descendents of id="img-div", so it was checking for their direct parent, expecting it to be "img-div" when really, in this case, it was the div with class "text-center".

So I refactored the tests to use jQuery's find() method which can find a child element nested at an arbitrary depth.

The last test was failing for a different reason - because it was trying to grab the id of the immediate parent element, which in this case, the <a> element did not have an id. So this is fixed as well.

However, I did want to point out that, even though this did not affect the tests, you do have an unclosed tag in your example. The anchor tag surrounding the image was not closed, I closed it here:
image

Anyway, no big deal! Thanks again for helping to improve this!

from testable-projects-fcc.

DarrenfJ avatar DarrenfJ commented on August 12, 2024

Thanks for pointing that out and glad I could have been some help.. 😃

from testable-projects-fcc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.