Comments (3)
@DarrenfJ you can go ahead and re-fix your pen if you'd like - I've forked your project here to preserve the issue. Thanks for reporting this! I'll look into this and should be able to fix.
Just to clarify though, on my end it seems to be failing #Content tests 4 & 5 and #Layout test 2 - not the last 3 tests, is that what you're seeing on your end? It's consistent with what you're describing as to why the tests fail
from testable-projects-fcc.
@DarrenfJ Thanks again for pointing this out - I've fixed the tests so now the broken one that I forked to preserve has all tests passing (with your original code). The issue was that the test was previously assuming id="image"
& id="img-caption"
would be a direct descendents of id="img-div"
, so it was checking for their direct parent, expecting it to be "img-div" when really, in this case, it was the div with class "text-center".
So I refactored the tests to use jQuery's find()
method which can find a child element nested at an arbitrary depth.
The last test was failing for a different reason - because it was trying to grab the id of the immediate parent element, which in this case, the <a>
element did not have an id. So this is fixed as well.
However, I did want to point out that, even though this did not affect the tests, you do have an unclosed tag in your example. The anchor tag surrounding the image was not closed, I closed it here:
Anyway, no big deal! Thanks again for helping to improve this!
from testable-projects-fcc.
Thanks for pointing that out and glad I could have been some help.. 😃
from testable-projects-fcc.
Related Issues (20)
- test issue when i'm working with survey project , test shows test failed list of tribute page HOT 1
- Test failing but test requirement has been met HOT 1
- getting an error on product landing page #landing test. it says the navbar should always be at the top of the page. the navbar is at the top of my page but i am still receiving the error. HOT 1
- FCC Personal Portfolio - Can't get Layout #3 test to pass regarding navbar and viewport HOT 2
- project verification script not detecting required id tags in my code HOT 1
- User Story #11: Within the form, there is a submit input with a corresponding id="submit" HOT 1
- Test scripts are not correct HOT 1
- Personal Portfolio Project Bugs
- i think this is bog, 3 hour i am trying HOT 1
- Pomodoro Clock #15 Test of "25 + 5" Test Suite May Be Yielding Incorrect Results HOT 3
- Survey Form Test Issues
- FCC: Tribute Page
- Potrfolio tests: typo in #Content test number 4
- the test is not running HOT 1
- Markdown Preview tests not compatible with Vue HOT 1
- TypeError: Cannot read property '1' of null for Pomodoro clock. Why?????!!!!!!! HOT 1
- Issue with image running Tribute Page tests HOT 2
- Dependency Dashboard
- Build a JavaScript Calculator tests typo HOT 3
- incomplete fix for 25+5 with React@18 in #1485
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from testable-projects-fcc.