TVrank should respect the `NO_COLOR` environment variable about tvrank

[caglaryucekaya]

Can I take this one too 😄

[fredmorcos]

Yes of course 😃 I think it might make sense to split it into a couple of separate issues and have an overall milestone. However you'd like to do it though it's up to you.

[caglaryucekaya]

I need some more clarification on this one. Currently the only colored part is the Rating column, and the colors are added in this part:

let rating_cell = Cell::new(rating_text).with_style(match rating { rating if rating.rating() >= 70 => GREEN, rating if (60..70).contains(&rating.rating()) => YELLOW, _ => RED, });

Is the issue that TvRank should stop doing this if the NO_COLOR variable exists, or is there a way to disable coloring completely in a more general way?

[fredmorcos]

As a first step, I think you need to handle two things:

1. Is the NO_COLOR environment variable set?
2. Is the --color command-line argument passed? (You will need to add support for the --color argument)

The latter takes precedence. Examples:

• If NO_COLOR is not set, and --color is not passed, then still show colors (the default).
• If NO_COLOR is set but --color is passed, then still show colors.
• If NO_COLOR is set and --color is not passed, then don't show colors.

The places where colors are displayed are the Rating column as you mentioned, and also the column titles that are displayed in bold (I guess this can also be considered coloring) under search::create_table():

  table.add_row(Row::new(vec![
    Cell::new("Primary Title").with_style(Attr::Bold),
    Cell::new("Original Title").with_style(Attr::Bold),
    Cell::new("Year").with_style(Attr::Bold),
    Cell::new("Rating").with_style(Attr::Bold),
    Cell::new("Votes").with_style(Attr::Bold),
    Cell::new("Runtime").with_style(Attr::Bold),
    Cell::new("Genres").with_style(Attr::Bold),
    Cell::new("Type").with_style(Attr::Bold),
    Cell::new("IMDB ID").with_style(Attr::Bold),
    Cell::new("IMDB Link").with_style(Attr::Bold),
  ]));