Coder Social home page Coder Social logo

Comments (4)

frankban avatar frankban commented on June 3, 2024 1

#147 is an attempt to fix this. That's released as v1.14.4. Quicktest now only suppress the got/want args if they are longer than ten lines (and -v is not provided). We can adjust this gradually as required, but it should address the cases you provided, in which the output for args is one line. Closing this ticket, but please reopen it if the fix is not good enough!

from quicktest.

rogpeppe avatar rogpeppe commented on June 3, 2024

Can you say specifically which output you're talking about please? An example would be helpful.

from quicktest.

bep avatar bep commented on June 3, 2024

@rogpeppe a simple example below.

  • Printing the full got/want is often much easier to reason about than the diff (especially true for tests you haven't looked at in a while)
  • It also allows you to more or less copy/paste the got into want in the test.
func TestFoo(t *testing.T) {
	c := qt.New(t)
	c.Assert([]string{"a", "b", "c", "d"}, qt.DeepEquals, []string{"a", "b", "c"})
}
--- FAIL: TestFoo (0.00s)
go test -run TestFoo     
slicehelpers_test.go:70: 
    error:
      values are not deep equal
    diff (-got +want):
        []string{
            "a",
            "b",
            "c",
      -     "d",
        }
    stack:
      /Users/bep/dev/go/bep/helpers/slicehelpers/slicehelpers_test.go:70
        c.Assert([]string{"a", "b", "c", "d"}, qt.DeepEquals, []string{"a", "b", "c"})
go test -v -run TestFoo     
slicehelpers_test.go:70: 
  error:
    values are not deep equal
  diff (-got +want):
      []string{
          "a",
          "b",
          "c",
    -     "d",
      }
  got:
    []string{"a", "b", "c", "d"}
  want:
    []string{"a", "b", "c"}
  stack:
    /Users/bep/dev/go/bep/helpers/slicehelpers/slicehelpers_test.go:70
      c.Assert([]string{"a", "b", "c", "d"}, qt.DeepEquals, []string{"a", "b", "c"})

from quicktest.

frankban avatar frankban commented on June 3, 2024

This behavior was introduced as a fix for #33
Probably we can investigate being a bit smarter about cases in which verbose should be required.
Single line values really do not increase the noise.

from quicktest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.