Comments (4)
#147 is an attempt to fix this. That's released as v1.14.4
. Quicktest now only suppress the got/want args if they are longer than ten lines (and -v is not provided). We can adjust this gradually as required, but it should address the cases you provided, in which the output for args is one line. Closing this ticket, but please reopen it if the fix is not good enough!
from quicktest.
Can you say specifically which output you're talking about please? An example would be helpful.
from quicktest.
@rogpeppe a simple example below.
- Printing the full got/want is often much easier to reason about than the diff (especially true for tests you haven't looked at in a while)
- It also allows you to more or less copy/paste the got into want in the test.
func TestFoo(t *testing.T) {
c := qt.New(t)
c.Assert([]string{"a", "b", "c", "d"}, qt.DeepEquals, []string{"a", "b", "c"})
}
--- FAIL: TestFoo (0.00s)
go test -run TestFoo
slicehelpers_test.go:70:
error:
values are not deep equal
diff (-got +want):
[]string{
"a",
"b",
"c",
- "d",
}
stack:
/Users/bep/dev/go/bep/helpers/slicehelpers/slicehelpers_test.go:70
c.Assert([]string{"a", "b", "c", "d"}, qt.DeepEquals, []string{"a", "b", "c"})
go test -v -run TestFoo
slicehelpers_test.go:70:
error:
values are not deep equal
diff (-got +want):
[]string{
"a",
"b",
"c",
- "d",
}
got:
[]string{"a", "b", "c", "d"}
want:
[]string{"a", "b", "c"}
stack:
/Users/bep/dev/go/bep/helpers/slicehelpers/slicehelpers_test.go:70
c.Assert([]string{"a", "b", "c", "d"}, qt.DeepEquals, []string{"a", "b", "c"})
from quicktest.
This behavior was introduced as a fix for #33
Probably we can investigate being a bit smarter about cases in which verbose should be required.
Single line values really do not increase the noise.
from quicktest.
Related Issues (20)
- stack trace's report of function+args can be unreasonably long for closures HOT 1
- All Auth HOT 2
- Add ErrorIs and ErrorAs checkers HOT 5
- assert: additional argument are not treated as comments HOT 1
- proposal: `Eventually` checker HOT 3
- confusing use of "unexpected success" when no errors are involved HOT 3
- Improve "negative" messages for standard checkers
- confusing failure when using qt.Equals with pointers HOT 2
- proposal: add Try and Recover HOT 8
- quicktest.Assert panics when called in a testscript command HOT 2
- Upgrade https://github.com/google/go-cmp HOT 1
- Omit package for types in current package
- LGPL license in checker.go HOT 3
- Not(DeepEquals) succeeds even though go-cmp panicked HOT 1
- name the package qt? HOT 6
- format uint64 differently. HOT 4
- add qt.IsNonNil HOT 6
- cmd/qtify HOT 6
- Improve README HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quicktest.