encoding ints to strings about gojay

[marcsantiago]

So I took a look at the standard libraries implementation
In decode.go line 867 the function called literalStore handles the string to numeric conversion.

In around 879 you can that fromQuoted variable is whats used to determine if the value has the string tag to conversions.

Later on on line 1013 you can see that within the switch block that a type conversion is being done

n, err := strconv.ParseInt(s, 10, 64)
if err != nil || v.OverflowInt(n) {
	d.saveError(&UnmarshalTypeError{Value: "number " + s, Type: v.Type(), Offset: int64(d.readIndex())})
	break
}
v.SetInt(n)

The encoding.go package in the std lib does not does not use the string tag. It uses the field type directly not the tag itself unless the tag is omitempty and in that case it skips the field is empty.

In that sense

enc.StringKey("offset", strconv.FormatInt(int64(f.Offset)))

it is still better as it does not rely on reflection to cast that value :-)