Comments (5)
Hey there – a way for Medium Zoom to understand which height to reset is to change the way the style is applied to the image. Do not apply the style with .images-block-image img
but rather attach a class to the images themselves.
You can find a working example in this sandbox.
The reason why you don't want to target the image with .selector img
is because Medium Zoom is unable to detect and remove this class to compute its zoomed size. If you attach the CSS class directly to the image, Medium Zoom is aware of where the style is coming from and can therefore reset it when zooming.
Let me know how it goes!
from medium-zoom.
I did what you suggested, the image that pops up is slightly better but your plugin clips it now, its not whole.
while this is the real size of the image:
here is some code for you how it looks after I zoom in with the plugin.
Can this be improved or am I stuck with this if I want gallery images with your plugin?
from medium-zoom.
your example has the same problem. Images real size is not respected, but they are clipped. My hope was that plugin would be able to go from whatever thumbnail size was to real size of the image.
Is this something that would be technically possible with your plugin? If you could do it, what it would cost if I was to compensate you, in case its not a simple fix?
I'd really like to use your plugin. I've got a great CMS on my hands and your plugin could be used on lots of websites built with my CMS.
See preview of it here
https://www.youtube.com/watch?v=pCjZpwH88Z0
And let me know if it would be possible to work with you to correct the above issues. I'll as mentioned compensate you for any additional work if you find it will take a while to correct this.
from medium-zoom.
object-fit: cover;
is more like the cause of the issue.
Line 54 in e082f9b
When the object-fit
CSS property is set, the height
and width
obtained here are not accurate
from medium-zoom.
A partial solution is to remove the special styles when opening:
const zoom = mediumZoom('[data-zoomable]');
zoom.on('open', event => {
event.target.style.height="auto";
event.target.style.width="auto";
});
zoom.on('opened', event => {
event.target.style.height=null;
event.target.style.width=null;
});
It doesn't animate the clipping, but at least shows the whole image
from medium-zoom.
Related Issues (20)
- Not work on <img> element in markdown. HOT 4
- Vitepress support HOT 2
- data-zoom-src not working with loading attribute HOT 5
- Pinching zoom option
- Nuxt with medium-zoom, weridly on the directly load in.
- SVG images sometimes don't have a '.svg' extension
- Gallery on full viewport mode (feature request) HOT 2
- Customize overlay HOT 1
- Working Nuxt3 example - add to README.md or separate page? HOT 1
- Cannot close overlay before `opened` event has fired. HOT 3
- Manipulation image size HOT 4
- Zoomed image size exceed intrinsic image size HOT 3
- use picture bed can't show image in website HOT 1
- The image is not centered and scale in iframe
- Not working after the page transition in Astro HOT 5
- There may be problems in some magnification situations. HOT 7
- If the image uses the srcset attribute, the pop-up layer will be displayed misaligned. HOT 1
- Tab doesn't close image if focused element is already visible on the screen
- Use the dialog element to display images HOT 2
- mediumZoom and Wordpress/Divi builder issue HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from medium-zoom.