Comments (5)
@edwardmeng I agree. I have been wanting to make some changes to the Foundatio metrics contract to allow adding tags/dimensions to metrics and I also wanted to create an AppMetrics implementation as well.
from foundatio.
They are working on a metrics.net net standard implementation and it was user contribed (on a side note). I also agree with the both of you but against removing metrics.net :)
from foundatio.
Wouldn't remove it. Would just add another implementation.
from foundatio.
@ejsmith I am wondering how to support tags/dimensions for statsd implementation. As I know the statsd does not support it be default.
from foundatio.
Sorry for the late reply @edwardmeng. Yeah, there are some implementations that would not be able to to support tagging/dimensions. So those would just be ignored. I am envisioning that we just add a method to let you create scopes that contain the dimensions on them and they just return the normal IMetricsClient back so none of the core contract would change. It would just be a matter of adding a method like this:
public interface IMetricsClient : IDisposable {
IMetricsClient BeginScope(IDictionary<string, object> data);
void Counter(string name, int value = 1);
void Gauge(string name, double value);
void Timer(string name, int milliseconds);
}
Then we would have extension methods with a fluent builder that let you build up the scope dictionary using a fluent lambda syntax which would be used something like this:
using (var scoped = client.StartScope(s => s.Tag("mytag").Dimension("host", "myhost1"))) {
scoped.Counter("mycounter");
}
Tags would just be added to the dictionary without any values. We could also add extension methods for the Counter, Gauge, Timer methods that let you add scope data to individual metrics by just wrapping the method in a BeginScope.
from foundatio.
Related Issues (20)
- Cancel queue job and clear the queue. Also disable job HOT 6
- publishAsync immediately returns when awaited HOT 4
- Feature Request : Priority Queues HOT 2
- InMemoryCacheClient SetAllAsync doesn't respect Expiry HOT 1
- GetFileListAsync - searchPattern
- Unified messaging HOT 1
- Upgrade Deprecated Azure SDK Clients HOT 6
- Split Foundatio.Extensions.Hosting in two HOT 4
- DataDictionary.Empty is not protected by potential bugs. HOT 3
- Throw exceptions on IFileStorage instead of returning false or null. HOT 4
- the question of Foundatio.Lock.ILockProvider HOT 3
- [Not a Bug] Discord Channel? I want to commit some example code HOT 1
- Examples for DependencyInjection HOT 4
- SaveFile Overload with Stream HOT 4
- RobiniaDocs API Explorer
- locks in async context HOT 2
- Is Pulsar supported HOT 1
- Writing InMemory stream results in NotSupportedException HOT 5
- Feature suggestion: Foundatio component for key vaults HOT 9
- messaging supporting Pulsar? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from foundatio.