Coder Social home page Coder Social logo

Comments (5)

ejsmith avatar ejsmith commented on July 22, 2024

@edwardmeng I agree. I have been wanting to make some changes to the Foundatio metrics contract to allow adding tags/dimensions to metrics and I also wanted to create an AppMetrics implementation as well.

from foundatio.

niemyjski avatar niemyjski commented on July 22, 2024

They are working on a metrics.net net standard implementation and it was user contribed (on a side note). I also agree with the both of you but against removing metrics.net :)

from foundatio.

ejsmith avatar ejsmith commented on July 22, 2024

Wouldn't remove it. Would just add another implementation.

from foundatio.

edwardmeng avatar edwardmeng commented on July 22, 2024

@ejsmith I am wondering how to support tags/dimensions for statsd implementation. As I know the statsd does not support it be default.

from foundatio.

ejsmith avatar ejsmith commented on July 22, 2024

Sorry for the late reply @edwardmeng. Yeah, there are some implementations that would not be able to to support tagging/dimensions. So those would just be ignored. I am envisioning that we just add a method to let you create scopes that contain the dimensions on them and they just return the normal IMetricsClient back so none of the core contract would change. It would just be a matter of adding a method like this:

public interface IMetricsClient : IDisposable {
   IMetricsClient BeginScope(IDictionary<string, object> data);
   void Counter(string name, int value = 1);
   void Gauge(string name, double value);
   void Timer(string name, int milliseconds);
}

Then we would have extension methods with a fluent builder that let you build up the scope dictionary using a fluent lambda syntax which would be used something like this:

using (var scoped = client.StartScope(s => s.Tag("mytag").Dimension("host", "myhost1"))) {
  scoped.Counter("mycounter");
}

Tags would just be added to the dictionary without any values. We could also add extension methods for the Counter, Gauge, Timer methods that let you add scope data to individual metrics by just wrapping the method in a BeginScope.

from foundatio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.