Comments (16)
@hongquan I agree with you that the design/layout is not optimal, in particular because the current repository combines in principle api wrappers for multiple languages.
I would suggest the following;
- rename the repository from
susi_api_wrapper
tosusi_python
- move the files from
susi_api_wrapper/python_wrapper
one level up, so directly into thesusi_python
repository - if need arrives, create new repos for different languages, like
susi_mono
etc ..
WDYT?
@cseas What do you think is needed there? A simple
cd susi_api_wrapper.git/python_wrapper
python3 setup.py bdist_wheel
already produces .whl packages. What else are you planning to do?
from susi_api_wrapper.
@cseas Yes, that is for sure the idea. I haven't seen any releases so we could very well create a 0.0.1 release, make a whl package, and upload it to the fossasia pip repository.
from susi_api_wrapper.
I understand that development is still ongoing and could change very often - but releases can really help start all the packaging bits. If you have trouble with PyPI I can help with all the uploading & updating etc given there are git tags.
The project status field in setup.py could always be used to indicate that it's still in early stage, just in case you have concern in releasing unstable things.
I would like to kick start the packaging bits in this year's GSoC, and this is one of the bottom-level dependencies of susi_linux tree.
from susi_api_wrapper.
Please go ahead with packaging. Would be great!
from susi_api_wrapper.
Honestly, I'm not consent about the design of this piece of software (susi_api_wrapper). I think it is better to reconstruct it before doing packaging.
I'm sorry that I don't have time to do it yet.
from susi_api_wrapper.
Can I work on creating a PyPi package for susi_python?
from susi_api_wrapper.
@norbusan Agree!
from susi_api_wrapper.
@norbusan Agree!
Can you create a susi_python
repo on github? Then I will move the current files over to preserve the history, and restructure it.
from susi_api_wrapper.
@norbusan I wasn't aware of the wheel generation. The README doesn't mention any wheel generation so I thought we just download the repository and run the program inside it by importing susi_python
.
I was thinking of releasing a PyPi package for this so the module can be install with pip install susi_python
from any terminal. That would make it easier for people to start using and experimenting with it.
from susi_api_wrapper.
@hongquan we could also physically rename the repository, but this is a bit brutal ... and would need adaption of the current raspi image generation (not mine, but the one that generates the current images by @Orbiter)
from susi_api_wrapper.
@norbusan That sounds good. Should I look into creating the PyPi package and see if it works well?
from susi_api_wrapper.
@cseas that is for sure a good idea. Things that need to be checked is whether e.g the RPi image with the normal susi_python removed from SUSI.AI folder, but installed via pip, then the susi_linux app still is working.
from susi_api_wrapper.
@norbusan Okay, I'll check it out.
from susi_api_wrapper.
@norbusan Added the repo susi_python
.
from susi_api_wrapper.
@hongquan I have moved the files with history, and added also Debian packaging. We should probably remove this repository or archive it?
from susi_api_wrapper.
@norbusan Archive it.
from susi_api_wrapper.
Related Issues (20)
- To add a way of changing the server whenever we get a server down error in between the conversation
- The youtube audio parser is running in an endless loop HOT 2
- Improper order of SUSI returning multiple actions
- Tizonia Not automatically Downloading on a New Pi System
- Send country name, code and device type in chat.json API HOT 2
- To show the speaker in the web client (chat.susi.ai) when the user logs in the speaker
- Make the JS API Wrapper for it HOT 2
- Set zoom for map as default value as in susi server
- To add VolumeAction class in the wrapper
- Stop Action only works for SUSI_API_Wrapper
- Convert to setuptools-based package
- To Update the endpoint to showcase Smart Speaker in device Section
- The installation Script of SUSI Linux repo failing due to some packages in API wrapper
- API parameters changed of Adding a new device on SUSI server
- Random text query error
- Set MapAction zoom parameter as default under model
- Correction in print statement in sample.py HOT 3
- Add Media Action parsing features
- Timezone consideration for chat
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from susi_api_wrapper.