Comments (21)
We need it for testing. So, non-developers can also test.
from susi_android.
@code-crusher @the-dagger There was an apk branch with a copy of the code from master. The goal of this issue is to have an apk only in that branch and nothing else at the moment. Please check out the example in the description (https://github.com/fossasia/open-event-orga-app/tree/apk). I deleted the apk branch as it did not fulfill the purpose.
from susi_android.
@code-crusher The branch is up.
https://github.com/fossasia/susi_android/tree/apk
from susi_android.
@mariobehling Fixed now.
@addiittya2006 Please try and run your changes once in the local fork before sending a pull request to verify that it works correctly. 🙂
from susi_android.
@mariobehling should the generated apk file be pushed in a folder in the master branch (similar to open-event-android) or in a new branch?
from susi_android.
I think I answered this in the issue description:
The event orga app adds an apk in the apk branch here, e.g. https://github.com/fossasia/open-event-orga-app/tree/apk. Please follow this approach and implement an automatic build after each code merge.
So, yes into a branch "apk".
from susi_android.
@mariobehling Thank you for clarification. Will start working on it.
from susi_android.
@mariobehling Not sure, why this is needed here. This is a normal Android app, not an app generator. We can't correlate open-event with this.
Open-event was a template and had a generator in it so on every PR push, an apk was generated, which makes sense for that particular purpose. No normal android apps have this feature, it's not needed. We can upload it to the Play store later.
This is just an android app. We don't need a build after every PR here.
from susi_android.
from susi_android.
@the-dagger can you create an orphan
branch apk
? :)
from susi_android.
@code-crusher Doing it in a min
from susi_android.
Please call the apk: susi.apk
from susi_android.
@the-dagger Also, #77 .
from susi_android.
What is missing to make this feature happening?
from susi_android.
I'm testing it @mariobehling.
Waiting for the Travis build to complete.
from susi_android.
@the-dagger Would be great to get this feature back.
from susi_android.
@mariobehling I'll fix this today.
from susi_android.
@the-dagger Should we move back to travis?
from susi_android.
@mariobehling I've fixed this in my fork with circleci.
Will send a PR with it today.
from susi_android.
@mariobehling fixed.
https://github.com/fossasia/susi_android/tree/apk
from susi_android.
Awesome!
from susi_android.
Related Issues (20)
- Incomplete Unit and UI testing HOT 1
- The sign in page is not working.
- implementation of databinding with live data (best practices)
- Speech to text button on chat activity not working HOT 1
- Search not working in groupWiseSkills, skills refetched every time filters are applied
- The margin is not centered on Skills page HOT 2
- Bump realm-gradle-plugin to 6.1.0 and fix build
- Add TRY button in the Skills List HOT 1
- Warnings of not translated strings in string.xml
- App cannot communicate with api.susi.ai on Android < 5.0 (probably) because TLS 1.2 is not enabled. HOT 2
- App crashes when I enter a question that is not easy answerable
- Remove background location access or document in a video why it is needed HOT 1
- Unable to rate skill when like or dislike option is clicked in the reply from susi.
- ForgotPasswordActivityTest is empty HOT 1
- Conda
- Can we try to port it to Flutter(Google's new UI toolkit) ? HOT 1
- Gradle.properties is giving an error that "set android.useAndroidX=true."
- Dependabot couldn't authenticate with https://jitpack.io
- Can't login
- Any plans for converting this whole apk into kotlin compose?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from susi_android.