Coder Social home page Coder Social logo

Comments (21)

mariobehling avatar mariobehling commented on June 12, 2024 4

We need it for testing. So, non-developers can also test.

from susi_android.

mariobehling avatar mariobehling commented on June 12, 2024 1

@code-crusher @the-dagger There was an apk branch with a copy of the code from master. The goal of this issue is to have an apk only in that branch and nothing else at the moment. Please check out the example in the description (https://github.com/fossasia/open-event-orga-app/tree/apk). I deleted the apk branch as it did not fulfill the purpose.

from susi_android.

the-dagger avatar the-dagger commented on June 12, 2024 1

@code-crusher The branch is up.
https://github.com/fossasia/susi_android/tree/apk

from susi_android.

the-dagger avatar the-dagger commented on June 12, 2024 1

@mariobehling Fixed now.
@addiittya2006 Please try and run your changes once in the local fork before sending a pull request to verify that it works correctly. 🙂

from susi_android.

code-crusher avatar code-crusher commented on June 12, 2024

@mariobehling should the generated apk file be pushed in a folder in the master branch (similar to open-event-android) or in a new branch?

from susi_android.

mariobehling avatar mariobehling commented on June 12, 2024

@code-crusher

I think I answered this in the issue description:

The event orga app adds an apk in the apk branch here, e.g. https://github.com/fossasia/open-event-orga-app/tree/apk. Please follow this approach and implement an automatic build after each code merge.

So, yes into a branch "apk".

from susi_android.

code-crusher avatar code-crusher commented on June 12, 2024

@mariobehling Thank you for clarification. Will start working on it.

from susi_android.

shivenmian avatar shivenmian commented on June 12, 2024

@mariobehling Not sure, why this is needed here. This is a normal Android app, not an app generator. We can't correlate open-event with this.

Open-event was a template and had a generator in it so on every PR push, an apk was generated, which makes sense for that particular purpose. No normal android apps have this feature, it's not needed. We can upload it to the Play store later.

This is just an android app. We don't need a build after every PR here.

from susi_android.

jigyasa-grover avatar jigyasa-grover commented on June 12, 2024

@mariobehling +1

from susi_android.

code-crusher avatar code-crusher commented on June 12, 2024

@the-dagger can you create an orphan branch apk? :)

from susi_android.

the-dagger avatar the-dagger commented on June 12, 2024

@code-crusher Doing it in a min

from susi_android.

mariobehling avatar mariobehling commented on June 12, 2024

Please call the apk: susi.apk

from susi_android.

addiittya2006 avatar addiittya2006 commented on June 12, 2024

@the-dagger Also, #77 .

from susi_android.

mariobehling avatar mariobehling commented on June 12, 2024

What is missing to make this feature happening?

from susi_android.

the-dagger avatar the-dagger commented on June 12, 2024

I'm testing it @mariobehling.
Waiting for the Travis build to complete.

from susi_android.

mariobehling avatar mariobehling commented on June 12, 2024

@the-dagger Would be great to get this feature back.

from susi_android.

the-dagger avatar the-dagger commented on June 12, 2024

@mariobehling I'll fix this today.

from susi_android.

mariobehling avatar mariobehling commented on June 12, 2024

@the-dagger Should we move back to travis?

from susi_android.

the-dagger avatar the-dagger commented on June 12, 2024

@mariobehling I've fixed this in my fork with circleci.
Will send a PR with it today.

from susi_android.

the-dagger avatar the-dagger commented on June 12, 2024

@mariobehling fixed.
https://github.com/fossasia/susi_android/tree/apk

from susi_android.

mariobehling avatar mariobehling commented on June 12, 2024

Awesome!

from susi_android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.