Comments (12)
Then yeah let us do it now as it is very likely that it might be used by some other component. Ill file a PR asap. 👍
from loklak_search.
@mariobehling
Do we want the hashtags related to the search term here ??
from loklak_search.
Do we want the hashtags related to the search term here ??
Either related to the search term or related to the tweets of the search output, e.g. show hashtags that appear in the search results.
@Orbiter: How can we get this from the API?
from loklak_search.
The best is to collect the hashtags from the search results and display them on the bottom of the page.
from loklak_search.
Hi! @mariobehling can I work on this issue?
from loklak_search.
Thanks! @mariobehling I am thinking of showing hashtags that appear in the search results.. They are present for every feed result at this route. http://api.loklak.org/api/search.json?q=fossasia
from loklak_search.
@uttu357 This will be nice start :)
Accumulate all the hashtags used in all the results along with frequencies and then show them in sorted order at the bottom.
Use ES6 syntax if possible :)
from loklak_search.
Sure! 👍
from loklak_search.
This issue is fixed for a start in the above PR #127. Now what we can work on this issue is making the hashtags
as sort of redux state. That is with each element when it arrives we also save the
The hashtags also which come with it.
What do you think @uttu357 ?
from loklak_search.
Making hashtags as sort of redux state is necessary and helpful when multiple components need them as is the case with the API Results and Query. If such a use case arises then we can move it and save it as a redux state?
Your thoughts? @hemantjadon
from loklak_search.
Well yeah right now there is only this component making use of the hashtags.
But this seems like the application component is keeping a slice of the data (computed from the state) and making a sort of personal state. Which should not be the case with a presentational component. Also it seems very likely that this hashtag data might be used by some other component.
We can maybe delay this for now, but eventually the state needs to move to store. So we can make a call here do it now or let the need arise and then do it later.
All opinions are welcomed :)
from loklak_search.
@uttu357 Sure :) Cheers :)
from loklak_search.
Related Issues (20)
- Shift Profile section above Top Twitterers and Top hashtags HOT 1
- Add Contact Us in the grid menu HOT 5
- Improve the UI of loklak.org/settings HOT 7
- Adding Badgeyay link to FOSSASIA Projects Menu HOT 2
- Redesigining Loklak Search Settings HOT 2
- Text overlaps in sidebar for some searches. HOT 7
- Updating the badgeyay icon.
- Security vulnerabilities in some dependencies HOT 3
- Update Issue Template #930
- Implementing Customization Similar to Susper.com HOT 5
- Adding Total Amount of Search results and time taken similar to Google Search HOT 5
- Contact Form Not wokring HOT 15
- Improving Terms and Privacy page UI HOT 2
- Contact form validation has discrepancies
- Security vulnerabilities: cryptiles & timespan HOT 1
- Add tests for media-wall component HOT 1
- Security vulnerability in Webpack-dev-server HOT 1
- Add newer projects to dropdown and minor UI fixes HOT 1
- Text instead of link in settings menu HOT 3
- Failed at the [email protected] postinstall script
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from loklak_search.