Comments (15)
Hi mappleconfusers,
From which source you took your opml file? Can you post a copy of it?
Thanks
from selfoss.
Certanly.
The file was an export of my Liferea feedlist.
This is how the problematic tags are written:
<outline title="Science" text="Science" description="Science" type="folder">
Here is the file: https://gist.github.com/mappleconfusers/5221555
from selfoss.
Ok thanks. So as there is no folders feature we can use the multi-tags feature in place. So I can propose to add a tag with the name of the folder for each source.
For the moment we only can filter items by one tag, but we can imagine to add the possibility to select more than one so it can be equivalent to folders and subfolders.
Do you think that's a good solution?
from selfoss.
I think that would certainly work and that this is probably the most feasible option.
Still you might want to consider these aspects which might cause problems in the future:
- If you implement opml-export the exported opml will not be the same as the imported one
- Tags are not Folders and will therefor be used differently than folders
- Highly nested folders might cause information-flooding (this could be solved by deleting tag-categories)
from selfoss.
So in this fix I handle your problem as I said with adding a tag for each parent folders. It's probably only a partial solution but I don't think that's in the philosophy of Selfoss to implents folders. Some erros are still here with your OPML file because Selfoss doesn't support Atom feeds.
I'm waiting for your feedback ;)
from selfoss.
I'm sorry I'm not very comfortable with Pull requests but you can find my modifications in my referenced commit ;)
from selfoss.
Ok. This seems to work. I still get errors, but I don't think this is caused by your code.
Like I feared the resulting taglist is pretty much a mess. Could you provide an option to use canonical names?
You said you are uncomfortable with pull requests: I think the trick is to create a dedicated branch for every request. Also if you want me to I would be happy to create a pull request for you :)
from selfoss.
What do you mean by canonical names?
Thanks, I just don't understand why in my pull request here #153 I can't just have the commit of my branch...
from selfoss.
Canonical names like unix paths for instance: newspaper/NY-Times/...
Do you know the Pull Request Docfile? https://help.github.com/articles/using-pull-requests
from selfoss.
When I am doing pull requests I normally use the following procedure:
- Create a branch that is up to date with the branch I want to pull request into
- Get my Commits on top of that (rebase/cherry-pick)
- Pull request
I did this here: https://github.com/mappleconfusers/selfoss/tree/pullreq_opml-folders
by using the commands:
git remote add pablor44 "https://github.com/pablor44/selfoss.git" # Add your repo as a remote
git remote update # Fetch all revisions from origin and your fork
git checkout origin/master -b pullreq_opml-folders # Check out the current state of the origin (SSilence / selfoss) into a new branch and switch to that branch
git cherry-pick 7082eb128d306e41caeb15ac09b8590dbc6932db # Cherry-Pick your referenced commit
git push origin pullreq_opml-folders # Upload the new branch
from selfoss.
ah ok, I missed the reference to the original repo when I created my branch, so I created it from my polluted master... Thanks I'll can submit clean pull request now :)
from selfoss.
Ok thanks! This time my PR is clean with only the commit that I want to submit!
from selfoss.
I tried with canonical names too but the result is not really readable because long tag names are not fully displayed...
from selfoss.
Works the current solution for all?
from selfoss.
Pull request #170 fix the few errors still returned about Atom feeds.
from selfoss.
Related Issues (20)
- Negative keyword filtering HOT 3
- Filter does not seem to work HOT 6
- upstream timed out HOT 3
- Cliupdate times out on cleaning thumbnails
- how to set the proxy HOT 1
- PHP 8.2.5 support? HOT 2
- Cannot export OPML HOT 4
- Deduplicate items across sources HOT 3
- Incorrect publishing times HOT 12
- Personalize source icon HOT 1
- Twitter : You currently have access to a subset of Twitter API v2 endpoints [...] HOT 2
- Custom spout not displayed in drop down menu HOT 2
- Item's date as a future date HOT 4
- The auto_collapse option is ineffective HOT 3
- Mark as read behavior with unread filter HOT 1
- The More button sometimes appears by mistake HOT 1
- Rss feed HOT 1
- Higher loglevel for authentication errors HOT 2
- Add support for dark mode HOT 2
- Too big icons on mobile phones
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from selfoss.