Delete resolve to early about fortune-postgres

[gr0uch]

The code for deletion is very simple, so simple that I wouldn't really know where the problem is:

fortune-postgres/lib/index.js

Lines 465 to 487 in 4f82729

	delete (type, ids) {
	if (ids && !ids.length) return super.delete()
	const Promise = this.Promise
	const client = this.client
	const typeMap = this.options.typeMap
	const primaryKey = this.keys.primary
	let index = 0
	/* eslint-disable prefer-template */
	const deleteRecords =
	`delete from "${typeMap[type] || type}"` +
	(ids ? ` where "${primaryKey}" in ` +
	`(${ids.map(() => {
	index++
	return `$${index}`
	}).join(', ')})` : '')
	/* eslint-enable prefer-template */
	return new Promise((resolve, reject) =>
	client.query(deleteRecords, ids ? ids : null,
	(error, result) => error ? reject(error) : resolve(result.rowCount)))
	}

Maybe you can confirm that this is the case by adding a find before you got the ConflictError?

[gr0uch]

Also the test for the adapter does create immediately after delete: https://github.com/fortunejs/fortune/blob/44e0469e9c81516c96066b9fcea2607900ee0397/test/unit/adapter.js#L584-L585

[thomasthiebaud]

Ok, so I add a find before using delete like this

beforeEach(function () {
    return store.adapter.find('user').then((res) => {
      console.log('RES')
      console.log(res)
      return database.truncate()
    });
  });

I get this output

RES
[ count: 0 ]

So there is not user. BUT if I go check in the database, there is one user (added throw fortunejs)

[thomasthiebaud]

If I'm switching from

function truncate() {
  return store.adapter.delete('user')
      .then(() => store.adapter.delete('customer'));
}

to

function truncate() {
  return store.adapter.delete('customer')
      .then(() => store.adapter.delete('user'));
}

I not longer have the error, but I don't know why

[gr0uch]

Hmm, I'm not sure where the problem is, since the tests for this adapter seem to do what you're trying to do without error.

Basically this should work:

return adapter.delete(type)
.then(() => adapter.create(type, records))

If that doesn't work then it would be a problem here.

[thomasthiebaud]

Ok I found why :

• I was mixing store.XYZ and store.adapter.XYZ
• When you create a record using store.adapter.create(type, records), records MUST be an array. Otherwise it will only call return new Promise().resolve()
• When adding data using store.adapter.create you have to manually insert relationship both in each parts. So in my case I had to put the customer id in user.customer and push the user id in the customer.users

[gr0uch]

Yup, Fortune.js handles relationships but the adapter doesn't.