Coder Social home page Coder Social logo

Comments (5)

mscfd avatar mscfd commented on June 16, 2024

The code in commit 185121f is a proof of concept, but works fine so far.

from ford.

ZedThree avatar ZedThree commented on June 16, 2024

Something a bit simpler that might be sufficient:

modified   ford/graphs.py
@@ -450,11 +450,11 @@ class TypeNode(BaseNode):
 
             node.visible = getattr(proto, "visible", True)
             if self in node.comp_of:
-                node.comp_of[self] += ", " + var.name
+                node.comp_of[self] += f"\n{var.name}"
             else:
                 node.comp_of[self] = var.name
             if node in self.comp_types:
-                self.comp_types[node] += ", " + var.name
+                self.comp_types[node] += f"\n{var.name}"
             else:
                 self.comp_types[node] = var.name
 

from ford.

mscfd avatar mscfd commented on June 16, 2024

This stacks names in a column, instead of printing them in a row, right? I have tried this, and it is definitely an improvement. But from looking at some of my graphs, I concluded that a compact box (a few lines with restricted width) uses the typical real estate in a graph optimally. That's why I arrived at my rather complex logic. I definitely would restrict the size of the label horizontally as well as vertically if there are too many items to avoid degenerating the graph.

from ford.

ZedThree avatar ZedThree commented on June 16, 2024

Have you looked at textwrap.wrap?

I do also think the graphs should be comprehensive rather than compact, so I don't think it should cut off components.

from ford.

mscfd avatar mscfd commented on June 16, 2024

Thanks for pointing to this module, did not know about it. Indeed something like textwrap.fill(s, width=40, max_lines=3, placeholder='...') yields the same result as my code block.

This is not about having compact graphs. It is about having readable graphs. I have already replaced the container by a container-fluid to really use my screen size for graphs, otherwise most graphs are unusable, see #293. With long edges (or long nodes), the whole graph shrinks and labels become unreadable without zooming.

One could question whether nesting levels greater than 2 or 3 are really necessary. But it really helps with refactoring and decoupling in a matured and grown code base.

from ford.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.