retr_file permissions issue in smb.py about impacket

[GoogleCodeExporter]

Hey Shawn:

Thanks for the bug report.. I'll try to reproduce the bug you're pointing out 
and I'll get back to you.. By any chance, did you test it under a newer OS 
(trying to understand whether the problem would happen at the smb2/3 layer too).

cheers,
beto

Original comment by [email protected] on 5 Jun 2014 at 8:28

[GoogleCodeExporter]

If needed I can provide a PCAP of the native LInux tool (smbclient) as well as 
smbclient.py as a basis for comparison.  

Original comment by [email protected] on 5 Jun 2014 at 8:28

[GoogleCodeExporter]

Yes please! :)

Original comment by [email protected] on 5 Jun 2014 at 8:29

[GoogleCodeExporter]

Point of fact I haven't tried it using SMB2/3.  I'll fire up a Win7 VM and run 
a similar test.  I'll let you know what I find out.  My initial suspicion was 
that it was in fact related to SMBv1.  

Original comment by [email protected] on 5 Jun 2014 at 8:30

[GoogleCodeExporter]

PCAPs attached!  Thanks for the swift response!

Original comment by [email protected] on 5 Jun 2014 at 8:37

Attachments:

• smbv1_access_denied.zip

[GoogleCodeExporter]

Using a similar configuration in Win7 everything works as expected.  The remote 
file downloaded without issue.

Original comment by [email protected] on 5 Jun 2014 at 9:11

[GoogleCodeExporter]

Shawn:

Indeed.. retr_file() (only in smb.py /v1) is trying to open the file (through 
nt_create_andx()) with write permissions. 
Actually nt_create_andx didn't accept any accessMask bits so I added that... 

I'm attaching you a new smb.py file.. could you please check it under your 
configuration? I'm gonna run the test cases here just to be sure everything's 
fine.

be sure to set the pythonpath to the right place so this smb.py is lodaded. If 
you have problems with this let me know..

thanks!
beto

Original comment by [email protected] on 5 Jun 2014 at 9:13

Attachments:

• smb.py

[GoogleCodeExporter]

Flawless victory!  That did the trick!!!!!  WinXP (smbv1) downloads are now 
working without issue.  Thanks again for the prompt response. 

Original comment by [email protected] on 5 Jun 2014 at 9:21

[GoogleCodeExporter]

Awesome!.. Thanks to you Shawn for taking the time to report this issue.. 

I'll update trunk tomorrow with this change.. 

Let me know if you find something else.. and enjoy impacket :)

beto

Original comment by [email protected] on 5 Jun 2014 at 9:24

[GoogleCodeExporter]

Fixed in http://code.google.com/p/impacket/source/detail?r=1228

Original comment by [email protected] on 5 Jun 2014 at 10:29

• Changed state: Fixed

[GoogleCodeExporter]

I seriously <3 impacket! (regards to pysmb) Thanks again for the swift action.  
It made me feel less crazy almost immediately :).

Original comment by [email protected] on 6 Jun 2014 at 1:19

[GoogleCodeExporter]

thanks for the good vibes :).. Craziness is welcome don't worry.. jump in here 
anytime if you need something..

beto

Original comment by [email protected] on 6 Jun 2014 at 1:33