Coder Social home page Coder Social logo

Comments (4)

rshriram avatar rshriram commented on May 31, 2024

A. if its going under tools, we need simple names. like loadgen or something. No point in having pseudonyms for every tool.
B. From my recollection, this was used as a way to learn Go. I am unclear why this tool is needed as a key dependency in Istio, when we have so many load generators out there. Granted that this has more flexibility but it is by no means standard/widely used. People are much more likely to believe in istio benchmarks from neutral party tools like wrk/h2load, instead of benchmark from our own tool (gives the impression of bias).
C. If we need this purely for internal testing in CI/CD, then this should probably be part of the test suite under tests/ directory, and should not be used in any way to provide official Istio benchmarks.

from fortio.

ldemailly avatar ldemailly commented on May 31, 2024

Thanks for your input and thoughts. As discussed previously, the repo will stay as is for now, for the following reasons:

  • it makes fortio "go get"able with a simple, short url go get -u istio.io/fortio
  • it keeps the resulting image and binary minimal and without external dependencies (beside grpc)
  • increased velocity and productivity:
    • it increases productivity - while istio/istio was in turmoil from mono repo and build changes, I was able to make half a dozen major feature improvements and releases
    • istio/istio still doesn't have daily/weekly releases
    • shuffling fortio code around in the current state isn't an effective use of precious time

We can revisit later but for now this would not be a productive/useful change for the Performance WG

from fortio.

geeknoid avatar geeknoid commented on May 31, 2024

We need to discuss as a whole the policy regarding repos in our organization. If all the ACLs described in the community roles document were applied at this point, the creation of this repo would likely not have been allowed.

We need to have a discussion whether to grandfather this repo in or not.

from fortio.

ldemailly avatar ldemailly commented on May 31, 2024

@smawson approved the repo creation - feel free to discuss with him or submit an agenda item to the perf wg

also please don't use github issues here for that kind of discussion

from fortio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.