Coder Social home page Coder Social logo

Comments (2)

the-chenergy avatar the-chenergy commented on June 18, 2024

I think the fix should be around here:

vscode.window.onDidCloseTerminal(() => {
codeManager.onDidCloseTerminal();
});

VSCode's API function onDidCloseTerminal seems to have one argument in the callback, the terminal being closed. I found an example usage of onDidCloseTerminal here in VSCode's tests.

So perhaps we can just check if the terminal that's closing matches the one recorded in CodeManager._terminal before setting that to null:

public onDidCloseTerminal(): void {
this._terminal = null;
}

from vscode-code-runner.

HoseynAAmiri avatar HoseynAAmiri commented on June 18, 2024

I just installed it and saw a similar effect. If you mess around with the terminals, it will add another one. If you have nothing, then run it via code runner, it keeps using it. I think it is like it remembers the index of the terminal and if it couldn't find it, it will create a new one even though the previously made terminal is somewhere there. It would be nice if it could remember its one and only generated terminal, or use the existing one that is most likely the relevant one to its own.

from vscode-code-runner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.